Scenarios using table showing up yellow in HTML output since 1.3.0

[fabrice31]

When you use a table in a scenario, the HTML output is showing in yellow.
(The console output is fine)

Example :

    Scenario: I test a table
       When I test data with:
       | name       | value       |
       | TheName | TheValue |

This issue happen only with version > 1.3.0

[mattwynne]

Would you be interested in working on a patch? I'm working on code for version 2.0 of Cucumber that will replace this faulty code, so I'm not motivated to go back into this code and fix bugs in it. Until 2.0 is released though, I'm sure our users would be grateful if you managed to fix it.

[fabrice31]

I tried, but I think I am not able to :(
The bug seems to come from this commit : cucumber/common@7dc7913
(the change of the formatter seems good, I don't know why it is wrong)
But when I unpack the gem and install it again, without any modification, it works again (I never did it before, I may do it wrong)

[ambirag]

@mattwynne i'll see if i can fix this because its impacting us as well

@fabrice31 are you not seeing this anymore after you reinstalled the cucumber ?

[fabrice31]

@ambirag update do 1.3.4, I am not seeing it anymore

[ambirag]

@fabrice31 we are using 1.3.4 and only started seeing this issue after upgrading to cucumber 1.3.4
Any scenario / scenario outline that has an inline table marked in yellow even thought it has passed.

[fabrice31]

@ambirag I had the opposit : a scenario that has inline table was always marked yellow, event though all has passed.

[bpattonjr]

I agree with @fabrice31 that it comes from the 7dc7913 commit.

I was able to fix it by reverting just the check for status.nil? on line 405 of lib/cucumber/formatter/html.rb that was added in that commit. And removing the status.nil? check doesn't seem to break the intended fix for #337, although I did not run all tests.

[mattwynne]

@os97673 can you take a look at this?

[os97673]

@mattwynne sure, I will, as soon as will be back from vacation ;) early next week

[os97673]

Ok, so it is status.nil? check which causes the problem.
But the real cause of the problem is that we call set_scenario_color on table cell value even if the table is not an examples table. In this case the table is just a data and has no status thus there is no reason to use it.

[os97673]

So, for now I will just add check if cell is part of Examples table.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.