Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace capturing groups with non-capturing in RbTransform#to_s #106

Merged
merged 1 commit into from
Sep 11, 2011

Conversation

twalpole
Copy link
Contributor

Instead of just removing all parentheses in RbTransform#to_s replace the capturing groups with non-capturing. This allows the use of the returned RbTransform object in more step definitions.

CAPTURE_MONEY = Transform /^(\$|£|€)(\d+)$/ do |currency, amount|
   ....
end

When /^I deposited (#{CAPTURE_MONEY})$/ do |money|
  ....
end

Without this change CAPTURE_MONEY.to_s returns $|£|€\d+ which will not match correctly in the step definiton. With this change it will return (?:$|£|€)(?:\d+) which will match correctly in the When step.

@mattwynne
Copy link
Member

Great idea, thanks!

@twalpole
Copy link
Contributor Author

@mattwynne glad you like it, makes transforms useful for me

@aslakhellesoy aslakhellesoy merged commit a1ae588 into cucumber:master Sep 11, 2011
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants