Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Step: Rename name to text #1130

Merged
merged 13 commits into from
Sep 27, 2017
Merged

Step: Rename name to text #1130

merged 13 commits into from
Sep 27, 2017

Conversation

olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Jun 24, 2017 •
edited
Loading

This PR is a follow-up to (the now-merged) cucumber/cucumber-ruby-core#137

It

  • renames Step's "name" to "text"
  • calculates widths of lines using the brand-new to_s implementation from Core

@olleolleolle olleolleolle self-assigned this Jun 24, 2017
@olleolleolle olleolleolle requested a review from brasmusson June 24, 2017 21:18
@olleolleolle
Copy link
Contributor Author

This is not all-right yet, I'm missing something, and the ./spec/cucumber/formatter/json_spec.rb does not do the right thing, yet.

@olleolleolle olleolleolle force-pushed the feature/issue-86-rename-step-name-to-step-text branch from 04b9e83 to cd56337 Compare July 8, 2017 10:19
@olleolleolle olleolleolle force-pushed the feature/issue-86-rename-step-name-to-step-text branch from cd56337 to d6fbf44 Compare September 27, 2017 19:24
@olleolleolle olleolleolle force-pushed the feature/issue-86-rename-step-name-to-step-text branch from d6fbf44 to fb2ae85 Compare September 27, 2017 19:29
@olleolleolle
Copy link
Contributor Author

Rebased on top of current master; sorry for churn.

@mattwynne mattwynne added this to the 3.0.0 milestone Sep 27, 2017
@ghost ghost assigned mattwynne Sep 27, 2017
@mattwynne mattwynne merged commit da8cf3c into master Sep 27, 2017
@mattwynne mattwynne added 💔 breaking change This will require a major release and removed type: refactoring / developer experience labels Sep 27, 2017
@lock
Copy link

lock bot commented Oct 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2018
@luke-hill luke-hill deleted the feature/issue-86-rename-step-name-to-step-text branch March 20, 2019 09:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brasmusson brasmusson Awaiting requested review from brasmusson

Assignees

@olleolleolle olleolleolle

@mattwynne mattwynne

Labels
💔 breaking change This will require a major release
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@olleolleolle @mattwynne