Frozen-string-literal fixes in eval'd code.

[pat]

Summary

The pragma comment doesn't pick up these uses because the code is eval'd on the fly.

Related:

• Improve frozen-string-literals compatibility. dblock/syntax#6
• Improve frozen-string-literals compatibility. aruba#436
• Updates for frozen-string-literal compatibility. rspec/rspec-core#2437

How Has This Been Tested?

I've managed to get the test suite passing locally with the --enable-frozen-string-literal RUBYOPT flag, using my own copy of Aruba plus some related upgrading changes because Cucumber's been locked to an old Aruba version for quite some time. I've also used the rspec-core test suite (which makes use of Cucumber) and my local cucumber copy to confirm their test suite is green as well.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Given the pragma comments, I'm presuming being frozen-string-literal-friendly is a goal of Cucumber, hence pretty confident in labelling this a bug fix :)

Checklist:

• I've added tests for my code
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

None of the checklist items here apply.

[danascheider]

@pat Some of the AppVeyor failures are fixed on master now - if you can rebase we can see if that fixes everything. Thanks for your help!

[pat]

@danascheider it seems the AppVeyor build's still broken? Or at the very least, I don't think my changes are the source of the problem… but I don't have a Windows machine at hand to test with.

If there's any debugging help I can do though, do let me know!

[enkessler]

The AppVeyor build was very briefly green at its start but didn't stay that way. It probably doesn't help that the Slack bot only posts about the Travis builds but the AppVeyor builds fail more quietly.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

[pat]

Can someone more knowledgeable let me know whether I should expect Appveyor to go green? Would rebasing this PR help matters? I don't feel I'm doing anything here that's going to behave differently on Windows.

[mattwynne]

@pat I think a rebase should help, yes. The appveyor build has been green recently.

[pat]

Indeed, looks like it's green now with the rebase :)

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

[pat]

Anything further I can do that'd be useful in getting this merged? :) The build is green! 💚

[olleolleolle]

LGTM!

[aslakhellesoy]

Hi @pat,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
• 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

[mattwynne]

Welcome @pat!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.