-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Cucumber Expressions, ref #1002 #1156
Conversation
I think this is pretty much done, apart from making a new release of Cucumber Expressions. I'm really excited about putting this in the next release. Any reservations/objections/questions? |
I've released cucumber-expressions 4.0.3. This can be merged to master now. Any objections or questions? |
Hi @aslakhellesoy, Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾 In return for we ask you to:
On behalf of the Cucumber core team, |
Wow thanks @aslakhellesoy! |
@aslakhellesoy So what's left on aruba's side is add the cucumber expression steps as well correct? |
@maxmeyer you mean translate, not add? If you have two or more expressions matching the same text, you'll get ambiguous errors. |
@aslakhellesoy Ah ok. Was not sure, if this would make a difference. So one can only have either regex or expression step because the expression is translated into regex by the extension? |
That's right. No need to translate the old regexps, but it might still make sense because it might make the step definitions more self-documenting. Here is the commit where it happened in Cucumber itself: 92208f6 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Support for Cucumber Expressions.
Because the Cucumber Expressions library can generate multiple expressions for an undefined step,
snippets contain all of them, with all but one commented out:
Checklist: