Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the support of old style tag expressions. #1314

Merged
merged 1 commit into from
Aug 5, 2018

Conversation

brasmusson
Copy link
Contributor

Summary

Remove the support of old style tag expressions.

Details

Remove the support for "~" and "," in tag expressions.
Still support the use of ~@no-clobber tagged hooks in aruba (that is convert '~@no-clobber' to 'not @no-clobber').

Motivation and Context

Old style tag expressions have been deprecated since v3.0.0, so their support should be removed in v4.0.0.

How Has This Been Tested?

The automated test suite has been updated to verify the changed behavior.

Types of changes

  • Refactor (code change that does not change external functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Remove the support for "~" and "," in tag expressions.
Still support the use of "~@no-clobber" tagged hooks in aruba.
@ghost ghost assigned brasmusson Aug 2, 2018
@brasmusson brasmusson merged commit 5c2a854 into master Aug 5, 2018
brasmusson added a commit that referenced this pull request Aug 5, 2018
@brasmusson brasmusson deleted the remove-old-tag-expressions branch August 5, 2018 11:31
@lock
Copy link

lock bot commented Aug 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant