Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cucumber pro publish job #1350

Merged
merged 1 commit into from
May 31, 2019
Merged

Remove cucumber pro publish job #1350

merged 1 commit into from
May 31, 2019

Conversation

luke-hill
Copy link
Contributor

@luke-hill luke-hill commented May 3, 2019 •
edited
Loading

Details

Removing a failing task from circleCI

Motivation and Context

It's long been failing, and was added a while back: 24e3a2e

In the SHA @mattwynne you mention adding an SSH key. Was this done? As it keeps failing for invalid authentication

Just trying to tidy up the build process with @olleolleolle to get everything green and trustworthy again

olleolleolle
olleolleolle approved these changes May 3, 2019
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be re-instated when there's energy for it.

@luke-hill
Copy link
Contributor Author

@mattwynne Are we ok to merge this?

@luke-hill luke-hill force-pushed the feature/remove_failing_publish_task branch from 7560899 to 84b8eb4 Compare May 23, 2019 07:09
@luke-hill luke-hill force-pushed the feature/remove_failing_publish_task branch from 84b8eb4 to d423b4e Compare May 27, 2019 07:57
@luke-hill luke-hill force-pushed the feature/remove_failing_publish_task branch from d423b4e to 352210c Compare May 28, 2019 11:17
@mattwynne
Copy link
Member

For sure! It would be good to set up publishing to Jam but we don't need to do it like this anymore.

@luke-hill luke-hill merged commit 07e1287 into master May 31, 2019
@luke-hill luke-hill deleted the feature/remove_failing_publish_task branch May 31, 2019 07:32
@lock
Copy link

lock bot commented Jun 24, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

@mattwynne mattwynne Awaiting requested review from mattwynne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luke-hill @mattwynne @olleolleolle