Defer at exit io close #1458
Merged
Defer at exit io close #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ister an event listener to close io in a at_exit hook Co-authored-by: Aslak Hellesøy <aslak.hellesoy@smartbear.com> Co-authored-by: vincent.capicotto <vincent.capicotto@hiptest.net>
aslakhellesoy
force-pushed
the
defer-at-exit-io-close
branch
from
132522a to
b57ef3e
Compare
Co-authored-by: Aslak Hellesøy <aslak.hellesoy@smartbear.com> Co-authored-by: vincent.capicotto <vincent.capicotto@hiptest.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, all
IOobjects created byensure_iowould be flushed and closed when Ruby exits.This turned out to be a problem for the new
--publishfunctionality if Cucumber raised an exception.One case where Cucumber will raise an exception (and not run anything) is when it's passed a non-existent feature file. It might also raise exceptions in other cases, for example when a feature file has syntax errors.
In those cases (where cucumber doesn't run anything), we don't want to publish any reports! However, since formatters (and their streams) are created before the exceptions described above are raised, it would already have registered the
at_exithooks that flush and close the streams (which in the case of--publishwill publish a report).The fix is to defer the registration of the
at_exithook which flushes and closes until we can be sure Cucumber isn't going to raise an error. If Cucumber raises an exception, theat_exithook won't have been registered.This change should preserve backwards compatibility.