HTML Formatter raises frozen string error

[jmerrifield]

After the changes in #159, when the HTML Formatter tries to append the class name of an exception to the message, if the message is frozen then a 'Cannot modify frozen string' exception is raised. This occurs when an exception has a frozen message attribute (e.g. in the case of Timeout::Error).

This pull request replaces the message variable with a concatenated string rather than attempting to append to it in-place.

[khustochka]

Occurring for me too. would be great if request accepted

[petemounce]

Us too; this nukes our test-run the first time we get a Timeout::Error (which is often; we're browser-automating a lot). Our test-runs take ~60min for the full set (parallelising our multi-tenant system already...), so this is expensive.

[siteriaitaliana]

Can you please accept this pull request, this issue is almost annoying me.

[oliversweb]

And occurring for me too. Fix would be great.

[taseri]

I'm also running into this issue, please fix.

[deepthini]

occurring for me too. please accept the request.

[gwilliams]

Also affecting me. Please pull this fix asap

[matteus6007]

This constantly slows down our CI builds as it prevents re-running failed tests

[jamesneville]

Likewise - biggest pain in my life right now - fix it please!

[StevoGo]

Affecting me as well. Please pull this fix!

[SujaJaganathan]

I'm inn as well

[SankalpMehra]

This is causing lot of problems. Please fix it.

[matthewdbell]

would be great for this to be fixed asap for me too

[ngandhi80]

Would really help if this gets fixed please

[BrewsterNZ]

My life would be so much better if this could get pulled! If someone could jump on it, it'll be much appreciated!
Thanks!

[gordonbaz]

Please pull this one, causing me much grief right now

[Becksh]

Also affecting me, please fix!!

[mikeward9]

Please can we get this pulled? We're having this trouble too

[dominic-perry]

This is a problem definitely causing headaches. Would be great to have this one sorted please.

[devn]

Please fix this.

[p0deje]

👍

[petemounce]

@moro @aslakhellesoy What is preventing this from being pulled?

[aslakhellesoy]

LGTM - the only blocker is time

[petemounce]

If it's pertinent, we've been running with a local build of the gem (forked from 1.1.4) for the last few weeks and haven't seen the error since updating to that local build.

[devn]

@aslakhellesoy Again, what is blocking this fix? It seems pretty straightforward to me. This is just pushing people away from cucumber when things like this take 2 months to get pulled. Someone did the work and it looks like a straightforward fix, why the twiddling of thumbs?

The issue queue is full, pull requests are at 13. What is the process for acceptance? Running cukes against this queue would produce timeouts and result in a frozen string error.

[aslakhellesoy]

@devn I'm busy that's all. I'll see if I can round up some more people to share responsibility for merging and releasing in a more timely manner. Nobody has volunteered, so I'll have to ask on the list.

I know you would probably step forward and volunteer, but it has to be someone I trust.

[petemounce]

@aslakhellesoy Thanks!

[devn]

@aslakhellesoy Thank you!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.