Wire protocol: display exceptions in hooks #435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mattwynne this ensures that prepare world is the first thing that is run for a test case, preventing the inconsistency with what the world _is_ in around hooks.
This is a deficiency in the legacy adapter somewhere.
Legacy adapter requires each test case to have a test step otherwise it doesn't switch step container and messages get lost. @mattwynne I think we might be able to deal with this if we switch step container in before_test_case, but it's something I would prefer to pair on you with? Seems like a big change, and maybe not something we need to worry about for 2.0?
Extra test step added back in
mattwynne
changed the title
|
I'd like to start again from scratch on this one. Closing. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #73.
I've investigated, and the cause is that the before/after code in the
central ProgrammingLanugage abstraction runs before the scenario has
started. This means any exceptions at this point are handled like
exceptions in the regular Cucumber source code, rather than
exceptions in the scenario.
I'm deferring this until 2.0
Update: 2015-03-16
Exceptions in Wire protocol hooks no longer crash the Cucumber process, as of #807. However the error from the hook is still not displayed, it looks like.