Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding code and specs for creating empty structure with --init switch #517

Closed
wants to merge 4 commits into from

Conversation

vestel
Copy link

@vestel vestel commented Aug 13, 2013

--init switch creates following structure

  • features\
    • step_definitions\
    • support\
      • env.rb
  • cucumber.yml

If 'features' folder or 'cucumber.yml' exist, it exits with error-code 1

FileUtils.cd(test_dir)
after_parsing('--init') do
output_stream.string.should =~ /Cucumber has build an empty folder structure/
File.exists?("cucumber.yml")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you forget some assertions here?

@tooky
Copy link
Member

tooky commented Sep 26, 2013

@vestel would you be able to pull behaviour out into a SkeletonCreator? Would be nice to get this in as a new feature for 2.0.

@vestel
Copy link
Author

vestel commented Sep 27, 2013

@tooky I'll try to find out how the best way to do it during this weekend

tooky and others added 4 commits September 27, 2013 10:25
* v1.3.x-bugfix:
  Disable minitest autorun after loading support code.
  Update History.md
  Remove scenarios checking for table deprecation warnings
  Add a non-mutating version of map_column
  Remove deprecation AST::Table warnings.

Conflicts:
	History.md
	features/docs/wire_protocol_table_diffing.feature
	legacy_features/table_mapping.feature
--init switch creates following structure 

- features\
  + step_definitions\
  + support\
    + env.rb
- cucumber.yml

If 'features' folder or 'cucumber.yml' exist, it exits with error-code 1
@vestel
Copy link
Author

vestel commented Sep 27, 2013

@tooky Can you take a look and correct me if something wrong. I'm really not sure how to do that

@vestel
Copy link
Author

vestel commented Sep 30, 2013

Travis CI build error has nothing common with my code. I don't understand why it appeared, since local build was clean and green at my box. What should I do next?

@brasmusson
Copy link
Contributor

The first time the Ruby 2.0.0 job failed with the error below, but when I restarted the job it passed:

(::) failed steps (::)
Exit status was 1 but expected it to be 0. Output:
Unable to contact the wire server at localhost:54321. Is it up? (Cucumber::WireSupport::Connection::ConnectionError)
/home/travis/build/cucumber/cucumber/lib/cucumber/wire_support/connection.rb:57:in `rescue in socket'
<snip>
Failing Scenarios:
cucumber -p ruby_2_0 features/docs/wire_protocol.feature:85 # Scenario: Dry run finds a step match

@mattwynne
Copy link
Member

Don't worry about the build failure then - thanks @brasmusson.

@vestel it's hard to review this PR because it contains 4b4cd78 which has a lot of changes in it, and aren't related to this change. Can you rebase your branch to just have the commits that you've made for this change?

@mattwynne
Copy link
Member

Superseded by #699. Thanks anyway @vestel!

@mattwynne mattwynne closed this Dec 22, 2014
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants