Fix #660 and let the rerun formatter include all examples rows when the background fails #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rerun formatter should not call status on Cucumber::Ast::ScenarioOutline elements.
Let the rerun formatter includes all example rows for a sceanrio outline if the background fails.
| @@ -54,7 +55,7 @@ def after_feature_element(feature_element) | |||
| def after_table_row(table_row) | |||
| return unless @in_examples and Cucumber::Ast::OutlineTable::ExampleRow === table_row | |||
| unless @header_row | |||
| if table_row.failed? | |||
| if table_row.failed? || table_row.status == :skipped | |||
There was a problem hiding this comment.
I wonder why we still do not have #skipped?? It looks strange to use method to check for one state and compare status to check for another.
There was a problem hiding this comment.
On 28 Mar 2014, at 07:12, Oleg Sukhodolsky notifications@github.com wrote:
I wonder why we still do not have #skipped?? It looks strange to use method to check for one state and compare status to check for another.
Yeah, but remember this code will die in 2.0
os97673
added a commit
that referenced
this pull request
Mar 28, 2014
…ure-v1.3.x Fix #660 and let the rerun formatter include all examples rows when the background fails
brasmusson
referenced
this pull request
Aug 6, 2014
Update the rerun_formatter.feature to specify that all example rows for a sceanrio outline should be included if the background fails. The rerun formatter itself was updated with this when the v1.3.x-bugfix branch was merged.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #660. The rerun formatter should check for Cucumber:Ast:ScenarioOutline before calling the status method, not after status already has been called.
The rerun formatter is updated to include all example row from example tables when the background fails.