V1.3.x: Support the cucumber-reporting tools also when using Scenario Outlines #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems work for me, appreciate for the solution. |
|
Rebased the PR so it merges cleanly with the latest changes in v1.3.x. |
mattwynne
added a commit
that referenced
this pull request
Aug 5, 2014
V1.3.x: Support the cucumber-reporting tools also when using Scenario Outlines
brasmusson
referenced
this pull request
Aug 6, 2014
Remove duplicate scenarios and add @wip-new-core to the outline expand scenario moved from the v1.3.x branch.
brasmusson
added a commit
that referenced
this pull request
Aug 12, 2014
Remove @wip-new-core from scenarios passed by this. The change from #700 is merged and working in both the v1.3.x branch and in the master branch, so now it is time to close cucumber/gherkin#165.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From reading the discussion in cucumber/gherkin#165, it is clear that people are pretty interested in being able to use the cucumber-reporting tools also together with Cucumber(-Ruby), see for instance comment1, comment2 and commen3 (the cucumber-reporting was initially developed to be used on Jenkins together with Cucumber-JVM).
The biggest obstacle to use it with Cucumber(-Ruby) is the very limited amount of information that end up in the JSON report for Scenario Outlines; no results, only the un-instantiated step (instead of the intantiated steps that actually was executed). One result of this problem is that the cucumber-reporting tools report "Result was missing for this step" (for the in-instantiated steps which are the only steps for the Scenario Outline included in the JSON report).
This PR changes the generated JSON report for Scenario Outlines when using the
--expandoption, to something the the cucumber-reporting tools can work on (that is, the same that Cucumber-JVM would have generated).Fixes cucumber/gherkin#165.