support embed plain/text in html report #712
Conversation
| @@ -49,6 +52,14 @@ def embed_image(src, label) | |||
| end | |||
| end | |||
|
|
|||
| def embed_image(src, label) | |||
There was a problem hiding this comment.
Did you mean to call this method embed_text?
There was a problem hiding this comment.
Already update this issue. Sorry for this.
|
Thanks for your contribution! I'd prefer to have a test for this new behaviour. The right place to add it is in https://github.com/cucumber/cucumber/blob/master/spec/cucumber/formatter/html_spec.rb @bingwei if you could have a go at writing a test that would be fantastic, but we can help out otherwise. Let us know. |
|
Sure, I'll add the test :) Thanks for quick reply! |
|
@mattwynne I've added test in target file. Please help review and merge my PR if possible |
|
Looks good to me! Thanks for your contribution @bingwei! |
support embed plain/text in html report
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
We have a project and we will generate a log file when something failed.
Currently we have to attach it to report as fake image.
But we prefer to add it as 'text/plain' mime type.
Could you support this feature? Thanks!
Link is here: cucumber/common#711