NoMethodError: undefined method `cell_matrix' for [...]:Cucumber::MultilineArgument::DataTable #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like the |
|
I will verify this e see any missing tests for |
WIP Making sure the table that is passed to users in their step defs conforms to the old API. This object will decorate the new, very simple, Core::Ast::DataTable. `cell_matrix` management is now happening here, and therefore all methods that operate on the `cell_matrix` can be created here.
tooky
referenced
this pull request
in cucumber/cucumber-ruby-core
Sep 5, 2014
This is related to cucumber/common#729
@mattwynne - I decided to try to make this simplest to get to green, we could make the old Table code just work to start with. The diff tests are all based on to_s working... I'm wondering if it's worth extracting that code out, and testing it seperately?
still doesn't work. I think it needs tests!
Enables to_s to print diffed tables. cc @mattwynne
This is ugly - I'm not seeing how to make it better. The two factory methods work quite differently. cc @mattwynne
This is a bit brittle, but probably ok as we'll be able to retire these formatters soon...
|
Weird. The wire protocol test that's failing is because it depends on |
I don't use this feature myself, so I'm not familiar with it, but from the look of this acceptance test, we were MUTATING THE AST OBJECT, THEN RENDERING IT. My head hurts. I'm just printing the nice diff output in the exception now, which I think reads better and also doesn't involve so much crazy coupling to the AST / formatters.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've played with test for http://youtrack.jetbrains.com/issue/RUBY-11291 and found that it raises exception with 2.0.0.beta.2
NoMethodError: undefined method
cell_matrix' for [{"type"=>"pending", "key"=>"FO-1"}]:Cucumber::MultilineArgument::DataTable ./features/step_definitions/ruby-11291.rb:5:in/^this table crashes:$/'/Users/user/work/tests/cucumber-tests/features/ruby-11291.feature:3:in `Then this table crashes:'
I'm not sure if calling
#diff!is still supported thus I've decided to file a ticket to discuss this.