fix issue #124 - JUnit expand option #808
Conversation
richarda
changed the title
richarda
changed the title
| end | ||
|
|
||
| context "In --expand mode" do |
There was a problem hiding this comment.
This is where the new tests start. Everything above was just moved into a context.
| @written_files[feature_filename] = data | ||
| module Cucumber | ||
| module Formatter | ||
| describe Junit do |
There was a problem hiding this comment.
changed module Cucumber::Formatter to
module Cucumber
module Formatter
to get runtime
|
I'm starting to feel guilty about pinging you about this one @richarda - it might well be too horrible to be worth it. For version 3.0, I want to re-write the formatters to use the new, much simpler formatter API, precisely to get rid of bugs like this. So if it looks too tricky, we can just put it into the 3.0 milestone and expect it to get fixed then. |
|
Don't feel guilty @mattwynne ... A silver lining: |
|
The actual fix of the issue is in cucumber/common@75b0975. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
@mattwynne Started looking at #124. For now, this failing unit test highlights the problem. I'm still looking at formatter/junit.rb to see if that's the place to handle
@option[:expand]