The check for multiple formatters using stdout is disabled when using profiles #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since all formatters but the first that are using STDOUT are removed when merging the profile options with the command line options, the check needs to be performed multiple times to catch all conflicts.
brasmusson
force-pushed
the
check-for-same-formatter-output
branch
from
9cb66f6 to
7b572e9
Compare
|
Now the check for multiple formatters using the same output stream/file/directory handle all cases. |
|
Looks good to me. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow the check for multiple formatters using stdout is disabled when using profiles (even when the profile does not define any formatter). See failing scenario.
The root cause of this behaviour is the logic for replacing the stdout formatter form the profile with the stdout formatter from the command line options. Since the code remove all but the first stdout formatters, you can define several stdout formatters on the command line without getting an error when using profiles, but only the first one will actually be used. This behaviour cased some confusion in this mailing list thread.
To cover all cases, the check for multiple formatters needs to be performed multiple times: