Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly close HTML formatter pre tag for leading comment #854

Merged
merged 2 commits into from
Jun 7, 2015

Conversation

pdswan
Copy link
Contributor

@pdswan pdswan commented May 20, 2015

closes #828

@brasmusson
Copy link
Contributor

@pdswan A tip, when you create a pull request for fixing an issue, do include "fixes #" in the description of the pull request (or any of the other keywords for closing issues), then the issue will be closed automatically when the pull request is merged. "see #" is not nearly as good, since it only creates a link to the issue, the issue will have to be closed manually when the pull request is merged (and yes, pull request descriptions can be edited after the pull request is created).

@mattwynne
Copy link
Member

...and also thanks @pdswan ;)

@mattwynne
Copy link
Member

Seriously, I do think this kind of edge-case would be better tested with a unit-test. The pretty_specs are in good shape IIRC and should be easy enough to add this example to. Did you try @pdswan?

@pdswan
Copy link
Contributor Author

pdswan commented May 20, 2015

@brasmusson that's certainly much more useful, isn't it. updated.

@mattwynne agreed and moved. could have sworn i looked for an appropriate unit spec last night 😕

@brasmusson brasmusson merged commit 4fd01ff into cucumber:master Jun 7, 2015
brasmusson added a commit that referenced this pull request Jun 7, 2015
Merge PR #854 "Properly close HTML formatter pre tag for leading comment"
@brasmusson
Copy link
Contributor

Merged, thanks for your contribution @pdswan.

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comments in feature-file cause issues in html-report
3 participants