Make the Rerun Formatter consistent with the exit code #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exit code is zero => the Rerun formatter output is empty The exit code is non-zero => the Rerun formatter output is not empty
|
This is going to need a little update to work since I tweaked the method name in cucumber/cucumber-ruby-core#92 |
brasmusson
force-pushed
the
rerun-formatter-exit-code
branch
from
dbdc338 to
fc356b1
Compare
|
So, it was easy enough to tweak the name used here too. |
mattwynne
added a commit
that referenced
this pull request
Jun 19, 2015
Make the Rerun Formatter consistent with the exit code
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the invariant for the behaviour of the Rerun Formatter should be:
When the exit code is zero => the Rerun formatter output is empty
When the exit code is non-zero => the Rerun formatter output is not empty
This PR changes the behaviour the Rerun Formatter to fulfil this invariant.
The final change (fc356b1) requires cucumber/cucumber-ruby-core#92.