Remove core_ext/proc.rb and use Proc#source_location instead #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create Cucumber::Core::Ast::Location from Proc#source_location and use it as the primary location. Only keep #file_colon_line as backward compatibility for Cucumber::Formatter::LegacyApi.
ghost
mentioned this pull request
mattwynne
added a commit
that referenced
this pull request
Aug 7, 2015
Remove core_ext/proc.rb and use Proc#source_location instead
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create Cucumber::Core::Ast::Location from Proc#source_location and use it as the primary location. Only keep #file_colon_line as backward compatibility for Cucumber::Formatter::LegacyApi.
Depends on (the recently made changes in Cucumber-Ruby-Core): Add factory method to Location for Proc#source_location output