Output bug fix. #918
Merged
Output bug fix. #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a bug that was causing the delayed output of #puts calls to be affected by modifications to its arguments that occurred between the time #puts was called and the time that its output was actually displayed.
|
On second thought, duplication via marshaling may have more problems than the test failure caused by #dup/#clone because it can't apply to all objects. |
Simpler and works on all objects.
#to_s won't work because it will simply return the original string if called on a String object, thus not achieving the point of the bug fix, which is to obtain a new copy of the object.
|
This should do the trick to fix #915 . |
brasmusson
added a commit
that referenced
this pull request
Nov 9, 2015
|
Merged. I added a spec in d5e0cfa. @enkessler I tip for PR:s that fixes issues it to include |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug that was causing the delayed output of #puts calls to be
affected by modifications to its arguments that occurred between the
time #puts was called and the time that its output was actually
displayed.
Fixes #915.