-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #927 - handle even more exotic rerun file formats seen in the wild #928
Conversation
@mcrmfc @mattwynne This fixed re-run issue for the parallel_cucumber. I have checked this by updating my test repo with Matt's fork. https://github.com/Shashikant86/parallel-cucumber-failed-rerun |
@@ -71,16 +71,17 @@ module Cli | |||
end | |||
end | |||
|
|||
context "contains features and scenarios with and without spaces same line and across lines" do | |||
context "contains features and scenarios with and without spaces on same line and across lines" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are a lot of rules in this example! I think it would be easier to read if you split it into several examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattwynne Parallel_test's Cucumber logger now creates this output without any space. It used to work well but this commit broken it grosser/parallel_tests#416
related issue can be found here grosser/parallel_tests#398
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattwynne - yep fair point, will break them out a bit - probably this should also be fixed in parallel_tests but since we don't constrain users via a known interchange format (json/yaml whatever) I guess there is no harm in defending against 🎃 👻 formats.. I'll break up the specs a bit.
Also, that is a very exotic format indeed! What is producing that output?! |
@mattwynne I have simplified the specs a little now. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Relates to #927 - handle more weird rerun formats.