Replace git through https as transport protocol #960
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace git through https as transport protocol since the latter is p…roxyable
Details
If a developer is required to access the WWW via a HTTP proxy, git cannot be used as transport protocol since it is not proxyable.
git
is set in https://github.com/cucumber/cucumber-ruby/blob/master/Gemfile#L11.Old:
New:
There might be other cucumber projects where such a change makes sense.
Motivation and Context
In bigger companies the use of HTTP proxies is quite common. There's not direct access from a laptop/computer to the WWW. Using
git
as transport protocol is a burden for new developers from such an environment as a local change is required each time they want to send a pull request. Since I've never had any performance impact in using HTTPS instead of GIT, put together this PR.How Has This Been Tested?
Yes, many times locally.
Screenshots (if appropriate):
Types of changes
Checklist: