Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace git through https as transport protocol #960

Merged
merged 1 commit into from
May 26, 2016

Conversation

ghost
Copy link

@ghost ghost commented Mar 24, 2016

Summary

Replace git through https as transport protocol since the latter is p…roxyable

Details

If a developer is required to access the WWW via a HTTP proxy, git cannot be used as transport protocol since it is not proxyable. git is set in https://github.com/cucumber/cucumber-ruby/blob/master/Gemfile#L11.

Old:

gem 'cucumber-core', :git => "git://github.com/cucumber/cucumber-ruby-core.git"

New:

gem 'cucumber-core', :git => "https://github.com/cucumber/cucumber-ruby-core.git"

There might be other cucumber projects where such a change makes sense.

Motivation and Context

In bigger companies the use of HTTP proxies is quite common. There's not direct access from a laptop/computer to the WWW. Using git as transport protocol is a burden for new developers from such an environment as a local change is required each time they want to send a pull request. Since I've never had any performance impact in using HTTPS instead of GIT, put together this PR.

How Has This Been Tested?

Yes, many times locally.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@maxmeyer maxmeyer force-pushed the feature/replace-git-through-https branch from 629cd23 to d389652 Compare March 24, 2016 20:38
@danascheider
Copy link
Contributor

Looks good to me.

@danascheider danascheider merged commit 348a225 into master May 26, 2016
@danascheider danascheider deleted the feature/replace-git-through-https branch May 26, 2016 16:47
@ghost
Copy link
Author

ghost commented Jun 7, 2016

@danascheider Thank you! :-)

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant