Fix regression displaying CLI help #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwynne
force-pushed
the
fix-regression-displaying-cli-help
branch
from
ec57acf to
78cedb6
Compare
|
I have no idea why the build is failing so disastrously for this little change, and I have run out of time to investigate. Sorry! |
mattwynne
force-pushed
the
fix-regression-displaying-cli-help
branch
from
78cedb6 to
3a27fa1
Compare
|
@brasmusson can you help me understand what's up with the build on this one? I can't reproduce it locally. |
mattwynne
force-pushed
the
fix-regression-displaying-cli-help
branch
from
3a27fa1 to
eb81b6b
Compare
|
OK I think I figured it out... Going to bed now but let's see what CI says. |
|
Phew fixed. Please merge when ready @cucumber/cucumber-ruby |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix regression displaying CLI help
Details
Added a test, added a quick fix.
Motivation and Context
cucumber --helpwas broken.How Has This Been Tested?
Added a new feature - surprised we didn't already have one!
Types of changes
Checklist: