Skip to content
This repository has been archived by the owner on Dec 21, 2022. It is now read-only.

CHANGELOG add for cucumber/cucumber #251 #1

Merged
merged 2 commits into from
Sep 8, 2017
Merged

CHANGELOG add for cucumber/cucumber #251 #1

merged 2 commits into from
Sep 8, 2017

Conversation

mxygem
Copy link
Member

@mxygem mxygem commented Sep 8, 2017

Summary

CHANGELOG.md add per cucumber/cucumber #251

Details

  • Added CHANGELOG.md
  • Note: Symbolic PR as I unintentionally pushed to master.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Documentation update

@d-led
Copy link
Contributor

d-led commented Sep 8, 2017

looks ok! Who can merge? @mattwynne I seem to have lost the rights to merge. Pull request #2 fixes the build

@mxygem
Copy link
Member Author

mxygem commented Sep 8, 2017

I can merge, but it'll need to be tomorrow when I'm on a computer. 'Pull requests that have a failing status can’t be merged on a phone.'

Failures don't have anything to do with my work.

@olleolleolle
Copy link
Contributor

@d-led There, a build fix, and you have commit bit again.

@d-led
Copy link
Contributor

d-led commented Sep 8, 2017

@jaysonesmith @olleolleolle ok! Will read up on cucumber/common#251

@d-led d-led merged commit 4f45d04 into master Sep 8, 2017
@olleolleolle olleolleolle deleted the changelog-add branch September 8, 2017 07:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants