Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: include message prop for pending steps #106

Merged
merged 2 commits into from
Nov 10, 2023
Merged

feat: include message prop for pending steps #106

merged 2 commits into from
Nov 10, 2023

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Nov 9, 2023 •
edited
Loading

🤔 What's changed?

When a step is pending, include a message string in the TestStepResult message.

⚡️ What's your motivation?

See cucumber/compatibility-kit#88 (comment)

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@davidjgoss davidjgoss marked this pull request as ready for review November 9, 2023 20:20
@davidjgoss davidjgoss merged commit dcdb76c into main Nov 10, 2023
3 checks passed
@davidjgoss davidjgoss deleted the feat/pending-message branch November 10, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luke-hill luke-hill luke-hill approved these changes

@mattwynne mattwynne Awaiting requested review from mattwynne

@mpkorstanje mpkorstanje Awaiting requested review from mpkorstanje

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidjgoss @luke-hill