Skip to content

Commit

Permalink
Fix messages dependency versions
Browse files Browse the repository at this point in the history
Allow messages v19.1.4 to v20.0.1 to be used by Javascript, PHP and Ruby.

With v19 [the messages protocol was expanded with keyword types][1]. Since
then no relevant changes for Gherkin have been made. This means we can expand
the range of allowed message versions somewhat.

1: https://github.com/cucumber/messages/blob/main/CHANGELOG.md#1900---2022-05-31
  • Loading branch information
mpkorstanje committed Dec 27, 2022
1 parent c3db155 commit 8e3d521
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ This project adheres to [Semantic Versioning](http://semver.org).
This document is formatted according to the principles of [Keep A CHANGELOG](http://keepachangelog.com).

## [Unreleased]
- [Javascript, PHP, Ruby] Allow messages v19.1.4 to v20.0.1 to be used

## [26.0.2] - 2022-12-27
### Fixed
Expand Down
2 changes: 1 addition & 1 deletion javascript/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"typescript": "4.9.4"
},
"dependencies": {
"@cucumber/messages": "^21.0.0"
"@cucumber/messages": "19.1.4 - 21"
},
"directories": {
"test": "test"
Expand Down
2 changes: 1 addition & 1 deletion php/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"require": {
"php": "^8.1",
"ext-mbstring": "*",
"cucumber/messages": "^21.0"
"cucumber/messages": "19.1.4 - 21"
},
"require-dev": {
"phpunit/phpunit": "^9.5",
Expand Down
2 changes: 1 addition & 1 deletion ruby/cucumber-gherkin.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Gem::Specification.new do |s|
'source_code_uri' => 'https://github.com/cucumber/gherkin/blob/main/ruby'
}

s.add_dependency 'cucumber-messages', '~> 19.1', '>= 19.1.4'
s.add_dependency 'cucumber-messages', '=> 19.1.4', '< 22'

s.add_development_dependency 'rake', '~> 13.0', '>= 13.0.6'
s.add_development_dependency 'rspec', '~> 3.11', '>= 3.11.0'
Expand Down

0 comments on commit 8e3d521

Please sign in to comment.