Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The minimum messages version should still be 19.1.4 #82

Closed
mpkorstanje opened this issue Dec 25, 2022 · 2 comments · Fixed by #83
Closed

The minimum messages version should still be 19.1.4 #82

mpkorstanje opened this issue Dec 25, 2022 · 2 comments · Fixed by #83

Comments

@mpkorstanje
Copy link
Contributor

mpkorstanje commented Dec 25, 2022

@mattwynne I do think it that the version just isn't declared correctly in the Gemfile. The minimum should still be 19.1.4. So using ~> is probably the wrong operator. We want multiple majors.

Looks like only Java got this right

<artifactId>messages</artifactId>
<version>[19.1.4,22.0.0)</version>

Originally posted by @mpkorstanje in #81 (comment)

@mpkorstanje
Copy link
Contributor Author

Perhaps we need to use the widen strategy.

https://docs.renovatebot.com/configuration-options/#rangestrategy

@mpkorstanje
Copy link
Contributor Author

This also applies to the HTML formatter.

Note: This may get confusing because NodeJS also has the peerDependency version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant