Allow messages v19.1.4 to v20.0.1 to be used #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpkorstanje
changed the title
mpkorstanje
changed the title
Allow messages v19.1.4 to v20.0.1 to be used by Javascript, PHP and Ruby. With v19 [the messages protocol was expanded with keyword types][1]. Since then no relevant changes for Gherkin have been made. This means we can expand the range of allowed message versions somewhat. 1: https://github.com/cucumber/messages/blob/main/CHANGELOG.md#1900---2022-05-31
mpkorstanje
force-pushed
the
use-messages-19-at-minimum
branch
from
8e3d521 to
660778a
Compare
This was referenced Dec 27, 2022
|
@mattwynne see also cucumber/html-formatter#206 Though there we are using |
davidjgoss
approved these changes
Dec 30, 2022
|
@davidjgoss what about the peer depencies? |
|
Oh sorry! For the html formatter it made sense for messages to be a peer dep because it’s used in the context of a cucumber implementation. Whereas usages of Gherkin can be more varied eg pretty printers, linters so making it a peer dep would add some overhead to those use cases. Maybe run with status quo for now and we can review this more broadly across the libraries? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Allow messages v19.1.4 to v20.0.1 to be used by Javascript, PHP and Ruby.
With v19 [the messages protocol was expanded with keyword types][1]. Since then no relevant changes for Gherkin have been made. This means we can expand the range of allowed message versions somewhat.
1: https://github.com/cucumber/messages/blob/main/CHANGELOG.md#1900---2022-05-31
The documentation for the syntax of each can be found here:
Fixes: #82
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.