Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: upgrade messages to v22 #133

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

dolmen
Copy link
Contributor

@dolmen dolmen commented Jul 13, 2023

Upgrade github.com/cucumber/messages/go from v21 to v22.

🤔 What's changed?

  • Change import in dialects_builtin.go.jq
  • Regenerate dialects_builtin.go
  • Change imports in other *.go.
  • go mod tidy to remove references to v21 and its dependencies

The changes were fully automated from CLI (note that those commands could be used to add a target in the Makefile):

$ cd go
$ sed -i '' 's!github.com/cucumber/messages/go/v21!github.com/cucumber/messages/go/v22!' dialects_builtin.go.jq
$ make dialects_builtin.go
$ sed -i '' 's!"github.com/cucumber/messages/go/v21"!"github.com/cucumber/messages/go/v22"!' *.go main/*.go
$ go mod tidy

⚡️ What's your motivation?

The renovate bot does a bad job. It doesn't update version references in Go sources. We can't trust it for Go.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

♻️ Anything particular you want feedback on?

No.

📋 Checklist:

@dolmen
Copy link
Contributor Author

dolmen commented Jul 14, 2023

Cc: @krichprollsch

Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do add an entry to the changelog.

Upgrade github.com/cucumber/messages/go to v22.

    cd go
    sed -i '' 's!github.com/cucumber/messages/go/v21!github.com/cucumber/messages/go/v22!' dialects_builtin.go.jq
    make dialects_builtin.go
    sed -i '' 's!"github.com/cucumber/messages/go/v21"!"github.com/cucumber/messages/go/v22"!' *.go main/*.go
    go mod tidy
@dolmen dolmen force-pushed the go-upgrade-messages-to-v22 branch from 4b95ace to 185b798 Compare July 17, 2023 14:12
@dolmen
Copy link
Contributor Author

dolmen commented Jul 17, 2023

@mpkorstanje

  1. Rebased (with conflict resolved)
  2. CHANGELOG entry added

@dolmen
Copy link
Contributor Author

dolmen commented Aug 6, 2023

Ping @mpkorstanje

@mpkorstanje mpkorstanje self-assigned this Aug 8, 2023
@mpkorstanje mpkorstanje merged commit 8692a24 into cucumber:main Aug 10, 2023
@mpkorstanje
Copy link
Contributor

Cheers!

mpkorstanje pushed a commit that referenced this pull request Aug 10, 2023
Upgrade github.com/cucumber/messages/go to v22.

    cd go
    sed -i '' 's!github.com/cucumber/messages/go/v21!github.com/cucumber/messages/go/v22!' dialects_builtin.go.jq
    make dialects_builtin.go
    sed -i '' 's!"github.com/cucumber/messages/go/v21"!"github.com/cucumber/messages/go/v22"!' *.go main/*.go
    go mod tidy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants