-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go: upgrade messages to v22 #133
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 13, 2023
dolmen
force-pushed
the
go-upgrade-messages-to-v22
branch
from
July 13, 2023 15:34
caa4983
to
4b95ace
Compare
Cc: @krichprollsch |
mpkorstanje
requested changes
Jul 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do add an entry to the changelog.
Upgrade github.com/cucumber/messages/go to v22. cd go sed -i '' 's!github.com/cucumber/messages/go/v21!github.com/cucumber/messages/go/v22!' dialects_builtin.go.jq make dialects_builtin.go sed -i '' 's!"github.com/cucumber/messages/go/v21"!"github.com/cucumber/messages/go/v22"!' *.go main/*.go go mod tidy
dolmen
force-pushed
the
go-upgrade-messages-to-v22
branch
from
July 17, 2023 14:12
4b95ace
to
185b798
Compare
|
1 task
Ping @mpkorstanje |
mpkorstanje
approved these changes
Aug 10, 2023
Cheers! |
mpkorstanje
pushed a commit
that referenced
this pull request
Aug 10, 2023
Upgrade github.com/cucumber/messages/go to v22. cd go sed -i '' 's!github.com/cucumber/messages/go/v21!github.com/cucumber/messages/go/v22!' dialects_builtin.go.jq make dialects_builtin.go sed -i '' 's!"github.com/cucumber/messages/go/v21"!"github.com/cucumber/messages/go/v22"!' *.go main/*.go go mod tidy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade
github.com/cucumber/messages/go
fromv21
tov22
.🤔 What's changed?
go mod tidy
to remove references tov21
and its dependenciesThe changes were fully automated from CLI (note that those commands could be used to add a target in the Makefile):
⚡️ What's your motivation?
The renovate bot does a bad job. It doesn't update version references in Go sources. We can't trust it for Go.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
No.
📋 Checklist: