Doc update #172
Merged
Doc update #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpkorstanje
reviewed
Sep 12, 2023
README.md
Outdated
| - [Objective-C](./objective-c) - Not tested? | ||
| - [Perl](./perl) - Tested on Perl 5.14 and 5.36 | ||
| - [PHP](./php) - Tested on PHP 8.1 | ||
| - [Dart](./dart) - Tested on Dart 1.4 |
There was a problem hiding this comment.
This is perishable information. It will go out of date when the Github Action is changed.
Consider removing the versions altogether and a second that describes how Gherkin is tested, refering to the CI files for specific versions.
There was a problem hiding this comment.
Fair point. But can you help with the 2 misunderstood ones? C/Obj C? Those appear wrong / untested
There was a problem hiding this comment.
C is tested by
https://github.com/cucumber/gherkin/blob/main/.github/workflows/test-c.yml
Objective-C is untested.
Maybe put that in the readme for objective-c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Add testing notes RE versions in readme
⚡️ What's your motivation?
Get more clarity on what is tested
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.