Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Irish translation for Rule #216

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Irish translation for Rule #216

merged 3 commits into from
Jan 19, 2024

Conversation

kieran-ryan
Copy link
Member

@kieran-ryan kieran-ryan commented Jan 16, 2024

🤔 What's changed?

Replace English Rule with Irish Riail.

⚡️ What's your motivation?

Correct a translation for Irish; assume was added initially as a default for compatibility with gherkin v6.

See translation in teanglann.ie.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

@kieran-ryan kieran-ryan self-assigned this Jan 16, 2024
@kieran-ryan kieran-ryan changed the title Fix Irish translation of Rule Irish translation for Rule Jan 16, 2024
@kieran-ryan kieran-ryan marked this pull request as ready for review January 16, 2024 20:54
Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but please keep this consistent with the other translations for the rule keyword and use the added header in the changelog.

Though I can certainly appreciate the irony of putting it under the fixed header. 😉

@kieran-ryan
Copy link
Member Author

Absolutely, aligned. Additionally included a missing PR reference for the unreleased addition of the Vietnamese Tule translation to Changelog (#204).

@kieran-ryan
Copy link
Member Author

kieran-ryan commented Jan 16, 2024

Appears to be some kind of intermittent failure with the cpp jobs. Initially failed, but succeeded after re-running. Not sure whether captured under an existing issue. Believe failure was same/similar to following job run: failed cpp job. Looks like there's been recent work merged on those jobs.

Edit: Raised as #217.

@kieran-ryan kieran-ryan merged commit 61b94aa into main Jan 19, 2024
32 checks passed
@kieran-ryan kieran-ryan deleted the fix-irish-rule branch January 19, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants