-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type annotations to the python codebase #283
Conversation
Perhaps instead of using typing.List instead of list for the typings, given I guess that we are so close to EOL for py3.8, should we just go for 3.9+? |
I fixed those lines, it was no big deal, so let's keep 3.8 until it goes EOL |
…ations # Conflicts: # .gitignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just my initial spots
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
🤔 What's changed?
py.typed
file markerThere are still quite some errors (actual bug, mypy idiosyncrasies, ...) , but at least all the signatures are annotated.
⚡️ What's your motivation?
Static type checking make things safer and easier to find usages.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.