Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby] Refactor/30 0 1 things #311

Merged
merged 24 commits into from
Nov 12, 2024
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
4219dae
Update changelog for python fix
luke-hill Oct 28, 2024
474bb04
Fix issue with methodname not remedying parser
luke-hill Oct 28, 2024
826fde4
AF: EmptyLineAfterMagicComment
luke-hill Oct 28, 2024
aaada99
AF: EmptyLinesAroundBlockBody
luke-hill Oct 28, 2024
ec2e5ed
Remedy tabbing
luke-hill Oct 28, 2024
0032224
Simplify TokenScanner#read
luke-hill Oct 28, 2024
809d844
AF: Lint/UnusedMethodArgument
luke-hill Oct 28, 2024
ea2d241
Fix Useless Variable Assignment
luke-hill Oct 28, 2024
0e40917
AF: Style/BlockDelimiters
luke-hill Oct 28, 2024
bc4fa61
AF: Style/ExpandPathArguments
luke-hill Oct 28, 2024
22db787
Regenerate TODO
luke-hill Oct 28, 2024
6b9bc28
Pull in cucumber-rails styles
luke-hill Nov 5, 2024
88ee6c8
AF: FrozenStringLiteral
luke-hill Nov 5, 2024
b27cf14
AF: Style/MultilineTernaryOperator
luke-hill Nov 5, 2024
6b80135
Alter razor template to give better name for state matching
luke-hill Nov 5, 2024
9a0fe15
Change lookahead method name and variable name of current token
luke-hill Nov 5, 2024
7e9a394
Fix up todo file and add override to generic styles
luke-hill Nov 5, 2024
12e872e
Regen parser
luke-hill Nov 5, 2024
3aed804
Mutate frozen string
luke-hill Nov 8, 2024
be02017
Remove concept of mutating frozen string, store memoized token reference
luke-hill Nov 8, 2024
3350775
Only perform token formatting when result is attempting to be fetched
luke-hill Nov 8, 2024
f05f7c8
Minor optimisation AstBuilder
luke-hill Nov 8, 2024
f1a06d7
Add note about ruby fixes
luke-hill Nov 8, 2024
9e87b33
Add note about internal refactor
luke-hill Nov 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix Useless Variable Assignment
luke-hill committed Oct 28, 2024
commit ea2d24144dbdd263f16d480ae60e7e65e1873f4e
2 changes: 1 addition & 1 deletion ruby/lib/gherkin/ast_builder.rb
Original file line number Diff line number Diff line change
@@ -116,7 +116,7 @@ def transform_node(node)
data_table = node.get_single(:DataTable)
doc_string = node.get_single(:DocString)

step = Cucumber::Messages::Step.new(
Cucumber::Messages::Step.new(
location: get_location(step_line, 0),
keyword: step_line.matched_keyword,
keyword_type: step_line.matched_keyword_type,
1 change: 0 additions & 1 deletion ruby/spec/gherkin/gherkin_spec.rb
Original file line number Diff line number Diff line change
@@ -26,7 +26,6 @@

it 'can set the default dialect for the feature file content' do
data = File.open('../testdata/good/i18n_no.feature', 'r:UTF-8', &:read)
data_without_language_header = data.split("\n")[1..-1].join("\n")

messages = Gherkin.from_source(
'uri',