Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perl: Use version range for messages #50

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Conversation

mpkorstanje
Copy link
Contributor

🤔 What's changed?

We did not specify a version range for the Cucumber::Messages dependency. This wasn't a problem before, every version of message was usable. However once cucumber/common#1741 was merged this was no longer true.

Fixes #48

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

I've used an lower and upper bound:

requires "Cucumber::Messages", ">= 19.0.0, < 20.0.0";

Perl does not appear to have JavaScripts equivalent for any later version within this major (e.g. ^19.0.0).

https://metacpan.org/pod/CPAN::Meta::Spec#Version-Ranges

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@mpkorstanje mpkorstanje marked this pull request as ready for review November 11, 2022 10:01
We did not specify a version range for the Cucumber::Messages dependency. This
wasn't a problem before, every version of message was usable. However once
cucumber/common#1741 was merged this was no longer
true.

Fixes #48
@mpkorstanje mpkorstanje force-pushed the perl-use-version-range branch from c706f36 to f5b7b06 Compare November 11, 2022 10:21
@mpkorstanje mpkorstanje merged commit f818210 into main Dec 2, 2022
@mpkorstanje mpkorstanje deleted the perl-use-version-range branch December 2, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

perl: Tests failing with older versions of Cucumber::Messages
1 participant