Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] Update target frameworks for .NET 6, .NET Framework 4.6.2, .NET Standard 2.0 and some improvments #67

Merged
merged 13 commits into from
Dec 17, 2022

Conversation

Romfos
Copy link
Contributor

@Romfos Romfos commented Dec 3, 2022

🤔 What's changed?

  • .NET SDK was updated to .NET 7
  • Target frameworks now: .NET 6, .NET Framework 4.6.2, .NET Standard 2.0
  • Unit tests now will run for .NET 6 and .NET 7
  • C# lang version was updated to 11
  • Added minimal .editorconfig with some basic settings

⚡️ What's your motivation?

Why target frameworks were changed?

Why lang version was updated?

Why target framework was changes for test project?

  • .NET 5 is out of support, .NET 6 and .NET 7 are supported versions

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@Romfos Romfos changed the title Update target frameworks for .NET 6, .NET Framework 4.6.2, .NET Standard 2.0 and some improvments [Dotnet] Update target frameworks for .NET 6, .NET Framework 4.6.2, .NET Standard 2.0 and some improvments Dec 3, 2022
@Romfos Romfos changed the title [Dotnet] Update target frameworks for .NET 6, .NET Framework 4.6.2, .NET Standard 2.0 and some improvments [dotnet] Update target frameworks for .NET 6, .NET Framework 4.6.2, .NET Standard 2.0 and some improvments Dec 3, 2022
@Romfos
Copy link
Contributor Author

Romfos commented Dec 3, 2022

Makefile was updated, please run ci one more time

@mpkorstanje mpkorstanje merged commit e318fd3 into cucumber:main Dec 17, 2022
@aslakhellesoy
Copy link
Contributor

Hi @Romfos,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@mpkorstanje
Copy link
Contributor

Cheers. Looked good enough to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants