added tests for "progress formatter"

cucumber · Oct 15, 2024 · 6211b3f · 6211b3f
1 parent 184b68b
commit 6211b3f
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 4 deletions.
diff --git a/internal/formatters/fmt_output_test.go b/internal/formatters/fmt_output_test.go
@@ -29,7 +29,7 @@ func Test_FmtOutput(t *testing.T) {
  featureFiles, err := listFmtOutputTestsFeatureFiles()
  require.Nil(t, err)
  // formatters := []string{"cucumber", "events", "junit", "pretty", "progress", "junit,pretty"}
- formatters := []string{"pretty"} //, "junit", "pretty", "progress", "junit,pretty"}
+ formatters := []string{"junit,pretty"}
  for _, fmtName := range formatters {
  for _, featureFile := range featureFiles {
  testName := fmt.Sprintf("%s/%s", fmtName, featureFile)

diff --git a/internal/formatters/fmt_progress.go b/internal/formatters/fmt_progress.go
@@ -98,6 +98,8 @@ func (f *Progress) step(pickleStepID string) {
  fmt.Fprint(f.out, red("F"))
  case undefined:
  fmt.Fprint(f.out, yellow("U"))
+ case ambiguous:
+ fmt.Fprint(f.out, yellow("A"))
  case pending:
  fmt.Fprint(f.out, yellow("P"))
  }
@@ -149,6 +151,16 @@ func (f *Progress) Failed(pickle *messages.Pickle, step *messages.PickleStep, ma
  f.step(step.Id)
 }
 
+// Ambiguous steps.
+func (f *Progress) Ambiguous(pickle *messages.Pickle, step *messages.PickleStep, match *formatters.StepDefinition, err error) {
+ f.Base.Ambiguous(pickle, step, match, err)
+
+ f.Lock.Lock()
+ defer f.Lock.Unlock()
+
+ f.step(step.Id)
+}
+
 // Pending captures pending step.
 func (f *Progress) Pending(pickle *messages.Pickle, step *messages.PickleStep, match *formatters.StepDefinition) {
  f.Base.Pending(pickle, step, match)

diff --git a/internal/formatters/formatter-tests/progress/some_scenarions_including_failing b/internal/formatters/formatter-tests/progress/some_scenarions_including_failing
@@ -1,4 +1,4 @@
-<green>.</green><red>F</red><cyan>-</cyan><yellow>P</yellow><cyan>-</cyan><yellow>U</yellow><cyan>-</cyan> 7
+<green>.</green><red>F</red><cyan>-</cyan><yellow>P</yellow><cyan>-</cyan><yellow>U</yellow><cyan>-</cyan><yellow>A</yellow><cyan>-</cyan> 9
 
 
 --- <red>Failed steps:</red>
@@ -8,8 +8,8 @@
  <red>Error: </red><bold-red>step failed</bold-red>
 
 
-3 scenarios (<red>1 failed</red>, <yellow>1 pending</yellow>, <yellow>1 undefined</yellow>)
-7 steps (<green>1 passed</green>, <red>1 failed</red>, <yellow>1 pending</yellow>, <yellow>1 undefined</yellow>, <cyan>3 skipped</cyan>)
+4 scenarios (<red>1 failed</red>, <yellow>1 pending</yellow>, <yellow>1 ambiguous</yellow>, <yellow>1 undefined</yellow>)
+9 steps (<green>1 passed</green>, <red>1 failed</red>, <yellow>1 pending</yellow>, <yellow>1 ambiguous</yellow>, <yellow>1 undefined</yellow>, <cyan>4 skipped</cyan>)
 0s
 
 <yellow>You can implement step definitions for undefined steps with these snippets:</yellow>