Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set viewport width to device width #238

Merged
merged 2 commits into from
Jun 2, 2023
Merged

Conversation

tim-yao
Copy link
Member

@tim-yao tim-yao commented May 27, 2023

🤔 What's changed?

Add the HTML's viewport meta tag to support mobile view.
See https://developer.mozilla.org/en-US/docs/Learn/CSS/CSS_layout/Responsive_Design#the_viewport_meta_tag

Before:
Screenshot 2023-05-27 at 1 12 08 pm

After:
Screenshot 2023-05-27 at 1 09 42 pm

⚡️ What's your motivation?

Fixes: #237

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

Not sure how to visually test it. But I add this line to my generated report does the job.

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@tim-yao tim-yao marked this pull request as ready for review May 27, 2023 03:14
@mpkorstanje mpkorstanje self-assigned this Jun 1, 2023
@mpkorstanje mpkorstanje self-requested a review June 1, 2023 11:29
@mpkorstanje mpkorstanje changed the title feat: add mobile device support Set viewport width to device width Jun 2, 2023
@mpkorstanje mpkorstanje merged commit cdf04dc into main Jun 2, 2023
@mpkorstanje mpkorstanje deleted the feat-mobile-device-support branch June 2, 2023 13:34
@mpkorstanje
Copy link
Contributor

Cheers. Released in v20.3.1. If you aren't using Cucumber-JVM you may have to poke some of the maintainers for a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile friendly report
2 participants