-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
step definition supports in php file #28
Conversation
Hi @shth - thanks for contributing this! I'm going to be away for little over a week - hope to look into this when I'm back. |
@aslakhellesoy No problem! Thanks in advance for the help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good start. I haven't had a chance to run the code yet. Could you please update your PR with the main
branch? The changes from #30 will introduce some merge conflicts, but overall it should simplify the code a bit.
I've made some more changes on |
b9a3ba6
to
52a346f
Compare
Hi @aslakhellesoy, I have rebased to the Sorry I went silent for a few days. |
Also thanks for the refactoring! It feels much cleaner to add languages now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work @shth! Regarding parameter types - this is a Cucumber Expressions concept. Since Cucumber Expressions aren't yet ported to PHP and integrated into Behat, it's correct to leave the defineParameterTypeQueries
as an empty array.
/cc @ciaranmcnulty
@aslakhellesoy thanks for the explanation. I have fixed the eslint errors btw. |
Hi @shth, Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾 In return for this generous offer we hope you will:
On behalf of the Cucumber core team, |
🤔 What's changed?
Added queries for tree sitter to grep the step definition node.
⚡️ What's your motivation?
I want to have code completion in php files
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
First of all, thanks to the person reviewing this 🙇. I am new to cucumber and tree-sitter and new to contributing to open source in general. So forgive me if something is obviously wrong.
Back to the code:
I could not find any docs about defining parameter types in PHP. Can anyone give me some pointers to docs/guides on how to do it? Thanks!
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.