Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Cucumber Expression optionals not preceded by space in suggestions #56

Merged
merged 1 commit into from
May 26, 2022

Conversation

aslakhellesoy
Copy link
Contributor

🤔 What's changed?

Optional text is now included in the suggestion unless it's preceded by a word (in which case it becomes suggestion options).

⚡️ What's your motivation?

The reason we include the optional in the text is that we cannot present a ['the ', ''] option to the user (where one of the options is an empty string). It cannot be represented in an LSP snippet choice

Also, this fixes #45

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ions
@aslakhellesoy aslakhellesoy enabled auto-merge May 26, 2022 08:01
@aslakhellesoy aslakhellesoy merged commit cad258a into main May 26, 2022
@aslakhellesoy aslakhellesoy deleted the handle-optionals-not-preceded-by-text branch May 26, 2022 08:02
@aslakhellesoy aslakhellesoy restored the handle-optionals-not-preceded-by-text branch May 26, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension Unable to Recognize Step Definitions Due to Parsing Error
1 participant