Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go: Tag releases with go/vVERSION #91

Closed
mpkorstanje opened this issue Dec 18, 2022 · 2 comments · Fixed by #93
Closed

go: Tag releases with go/vVERSION #91

mpkorstanje opened this issue Dec 18, 2022 · 2 comments · Fixed by #93

Comments

@mpkorstanje
Copy link
Contributor

From the go docs:

https://go.dev/ref/mod#vcs-version
If a module is defined in a subdirectory within the repository, that is, the module subdirectory portion of the module path is not empty, then each tag name must be prefixed with the module subdirectory, followed by a slash. For example, the module golang.org/x/tools/gopls is defined in the gopls subdirectory of the repository with root path golang.org/x/tools. The version v0.4.0 of that module must have the tag named gopls/v0.4.0 in that repository.
@mpkorstanje
Copy link
Contributor Author

But I should double check this.

Also gotta tag the latest releases of Gherkin and Messages

@mpkorstanje
Copy link
Contributor Author

mpkorstanje commented Dec 22, 2022 •
edited
Loading

Check results with https://sum.golang.org/lookup/github.com/cucumber/messages/go/v21@v21.0.1, there may be some delay.

@mpkorstanje mpkorstanje mentioned this issue Dec 23, 2022
Merged
7 tasks
@mpkorstanje mpkorstanje changed the title go: Tag releases with go/VERSION go: Tag releases with go/vVERSION Dec 27, 2022
mpkorstanje added a commit that referenced this issue Dec 27, 2022
@mpkorstanje
go: Tag polyglot go releases with go/vVERSION
5e1026c 
> https://go.dev/ref/mod#vcs-version
> If a module is defined in a subdirectory within the repository, that is, the
> module subdirectory portion of the module path is not empty, then each tag
> name must be prefixed with the module subdirectory, followed by a slash. For
> example, the module golang.org/x/tools/gopls is defined in the gopls
> subdirectory of the repository with root path golang.org/x/tools. The
> version v0.4.0 of that module must have the tag named gopls/v0.4.0 in that
> repository.

Currently, releases are only tagged with `vVERSION`. So to make go happy we
have to add a `go/vVERSION` tag.

Fixes: #91
mpkorstanje added a commit that referenced this issue Dec 27, 2022
@mpkorstanje
go: Tag polyglot go releases with go/vVERSION
569d480 
> https://go.dev/ref/mod#vcs-version
> If a module is defined in a subdirectory within the repository, that is, the
> module subdirectory portion of the module path is not empty, then each tag
> name must be prefixed with the module subdirectory, followed by a slash. For
> example, the module golang.org/x/tools/gopls is defined in the gopls
> subdirectory of the repository with root path golang.org/x/tools. The
> version v0.4.0 of that module must have the tag named gopls/v0.4.0 in that
> repository.

Currently, releases are only tagged with `vVERSION`. So to make go happy we
have to add a `go/vVERSION` tag.

Fixes: #91
mpkorstanje added a commit that referenced this issue Dec 27, 2022
@mpkorstanje
go: Tag polyglot go releases with go/vVERSION
a8e13d4 
> https://go.dev/ref/mod#vcs-version
> If a module is defined in a subdirectory within the repository, that is, the
> module subdirectory portion of the module path is not empty, then each tag
> name must be prefixed with the module subdirectory, followed by a slash. For
> example, the module golang.org/x/tools/gopls is defined in the gopls
> subdirectory of the repository with root path golang.org/x/tools. The
> version v0.4.0 of that module must have the tag named gopls/v0.4.0 in that
> repository.

Currently, releases are only tagged with `vVERSION`. So to make go happy we
have to add a `go/vVERSION` tag.

Fixes: #91
mpkorstanje added a commit that referenced this issue Dec 27, 2022
@mpkorstanje
go: Tag polyglot go releases with go/vVERSION
1d41ce7 
> https://go.dev/ref/mod#vcs-version
> If a module is defined in a subdirectory within the repository, that is, the
> module subdirectory portion of the module path is not empty, then each tag
> name must be prefixed with the module subdirectory, followed by a slash. For
> example, the module golang.org/x/tools/gopls is defined in the gopls
> subdirectory of the repository with root path golang.org/x/tools. The
> version v0.4.0 of that module must have the tag named gopls/v0.4.0 in that
> repository.

Currently, releases are only tagged with `vVERSION`. So to make go happy we
have to add a `go/vVERSION` tag.

Fixes: #91
mpkorstanje added a commit that referenced this issue Dec 27, 2022
@mpkorstanje
go: Tag polyglot go releases with go/vVERSION
bd0e292 
> https://go.dev/ref/mod#vcs-version
> If a module is defined in a subdirectory within the repository, that is, the
> module subdirectory portion of the module path is not empty, then each tag
> name must be prefixed with the module subdirectory, followed by a slash. For
> example, the module golang.org/x/tools/gopls is defined in the gopls
> subdirectory of the repository with root path golang.org/x/tools. The
> version v0.4.0 of that module must have the tag named gopls/v0.4.0 in that
> repository.

Currently, releases are only tagged with `vVERSION`. So to make go happy we
have to add a `go/vVERSION` tag.

Fixes: #91
@mpkorstanje mpkorstanje mentioned this issue Dec 27, 2022
Merged
mpkorstanje added a commit that referenced this issue Dec 27, 2022
@mpkorstanje
go: Tag polyglot go releases with go/vVERSION (#93)
828cf28 
> https://go.dev/ref/mod#vcs-version
> If a module is defined in a subdirectory within the repository, that is, the
> module subdirectory portion of the module path is not empty, then each tag
> name must be prefixed with the module subdirectory, followed by a slash. For
> example, the module golang.org/x/tools/gopls is defined in the gopls
> subdirectory of the repository with root path golang.org/x/tools. The
> version v0.4.0 of that module must have the tag named gopls/v0.4.0 in that
> repository.

Currently, releases are only tagged with `vVERSION`. So to make go happy we
have to add a `go/vVERSION` tag.

Fixes: #91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

go: Tag polyglot go releases with go/vVERSION cucumber/polyglot-release
1 participant
@mpkorstanje