go: use only major version in the module name #86
+60
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpkorstanje
force-pushed
the
go-use-only-major-version-in-module
branch
from
463e8a1 to
735b135
Compare
7 tasks
mpkorstanje
force-pushed
the
go-use-only-major-version-in-module
branch
2 times, most recently
from
0253490 to
0bb41d6
Compare
mpkorstanje
force-pushed
the
go-use-only-major-version-in-module
branch
from
0bb41d6 to
bcabe9e
Compare
Following on cucumber/messages#107 we can conclude that 1. only major versions should be used in go module files 2. some project will have been released with a major.minor.patch version This change will ensure that when a new major release is made: `module github.com/example/project/v0` will become `module github.com/example/project/v1` and: `module github.com/example/project/v0.X.X` will become: `module github.com/example/project/v0`. This should fix the incorrect module names on the next major version.
mpkorstanje
force-pushed
the
go-use-only-major-version-in-module
branch
from
bcabe9e to
27211e9
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Following on cucumber/messages#107 we can conclude that
This change will ensure that when a new major release is made:
module github.com/example/project/v0will becomemodule github.com/example/project/v1and:
module github.com/example/project/v0.X.Xwill become:module github.com/example/project/v0.This should fix the incorrect module names on the next version.
🏷️ What kind of change is this?
📋 Checklist: