Illegal escape detection #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslakhellesoy
added a commit
that referenced
this pull request
Oct 18, 2021
* Use shared test data * Fix stryker * Refactor Java tests to read from YAML. Harmonize error messages. * Go tests use yaml test data * Ruby: tests based on yaml testdata (found a bug) * Make empty expression evaluate to true in Ruby (as it does in other implementations) * Illegal escape detection (#17) * Throw error on illegal escapes * Fix JavaScript tests, simplyfy Java * Update Ruby parser * Document escaping. Fixes #16. * Fix go escape validation (simplify java) * Add new test: 'a and or' * Add testcase: 'a and b and c'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only allow escape character (
\) in front of(,),\. Throw error otherwise.Motivation & context
It makes the grammar less ambiguous.
Type of change
work as expected)
Update required of cucumber.io/docs