Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cleanup nft, addressbook and marketplace module #103

Merged
merged 5 commits into from
Dec 22, 2023
Merged

chore: cleanup nft, addressbook and marketplace module #103

merged 5 commits into from
Dec 22, 2023

Conversation

tuantran1702
Copy link
Contributor

@tuantran1702 tuantran1702 commented Dec 20, 2023 •
edited
Loading

Description

This PR removes nft, addressbook and marketplace modules.

Closes #97, closes #98 and closes #99

@tuantran1702 tuantran1702 mentioned this pull request Dec 20, 2023
Closed
@tuantran1702 tuantran1702 marked this pull request as ready for review December 20, 2023 06:27
@nghuyenthevinh2000 nghuyenthevinh2000 mentioned this pull request Dec 21, 2023
Closed
@nghuyenthevinh2000
Copy link

LGTM!

jgtormo
jgtormo reviewed Dec 21, 2023
View reviewed changes
app/app_upgrades.go Show resolved Hide resolved
x/nft/client/cli/cli_test.go Show resolved Hide resolved
@jgtormo jgtormo merged commit 994a9ec into cudoventures:dev Dec 22, 2023
2 checks passed
@tuantran1702 tuantran1702 deleted the cleanup_modules branch December 29, 2023 15:58
@nghuyenthevinh2000 nghuyenthevinh2000 mentioned this pull request Jan 2, 2024
Closed
14 tasks
@tuantran1702 tuantran1702 mentioned this pull request Jan 15, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nghuyenthevinh2000 nghuyenthevinh2000 nghuyenthevinh2000 left review comments

@jgtormo jgtormo jgtormo approved these changes

@nbaum nbaum Awaiting requested review from nbaum nbaum is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove addrbook module Remove marketplace module in dev branch Remove NFT module in dev branch
4 participants
@tuantran1702 @nghuyenthevinh2000 @jgtormo @dao-notional