-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibilidade de criar os índices extras via CLI #292
Open
mbnunes
wants to merge
11
commits into
cuducos:main
Choose a base branch
from
mbnunes:extra_indexes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
04b7f17
primeiro commit do extra-indexes
mbnunes 349a003
indices no postgres sendo criados um a um,
mbnunes d1c91c8
Update db/mongodb.go
mbnunes b065fbb
Update cmd/cmd.go
mbnunes 22d44af
alteracao para Sprintf
mbnunes d232f12
ajustes no cobra porem nao terminado
mbnunes 8031950
gofmt executado
mbnunes 4a1e6c1
Update db/postgres.go
mbnunes 0092d67
count indexes created
mbnunes cc7a012
extra-indexes
mbnunes 728d3cd
correcoes na nomeclatura salva no Mongo para os indexes
mbnunes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Isso aqui não é uma boa prática: concatenar strings para formar um SQL e escrever SQL dentro do Go. Melhor usar templates — por segurança, por facilidade de leitura e manutenção, e para manter o padrão de todos os outros comandos SQL que o módulo Postgres implementa. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Essa lógica está verbosa demais, não entendi o input como
qsa_
(achava que seriaqsa.
como sugerido anteriormente), e acho que não precisamos de dois blocos, um para QSA e outro para CNAEs secundários.Os inputs serão, por exemplo,
qsa.codigo_pais
ecnaes_secundarios.codigo
e queremosqsa_codigopais
ecnaessecundarios_codigo
, é isso?Se for:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eu sei qa lógica não está das mais explicadas. E porque eu pensei no seguinte, se o usuário escrever como está o ouput da API ele vai por:
cnaes_secundarios.codigo
E não como está no mongo que e cnaesecundarios.codigo
Por isso coloquei os ifs de "conversão"
De fato havíamos falado . ao invés de _. Desculpe não sei aonde meu TDAH foi parar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Já que não está claro, isole essa função e adicione nos testes, aí garantimos, nos testes, que o que a pessoa digitar gera o nome esperado no banco : )