Skip to content

Commit

Permalink
internal/core/adt: fix 2052 for eval v3
Browse files Browse the repository at this point in the history
Now we finalize the source node for a
for comprehension explicitly, we no longer
need to use "require" to get the initial node.
This avoid some eager evaluation that breaks
2052.

We also relax the added conditions in
CallExpr.evaluate, as it caused a similar
issue with eager evaluation with the
"if" version of a the reducers for Issue
2052.

Issue #2052 (already fixed and closed for v2)

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: I016959f07285ba17b555e54234e49386a84dc71f
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1206327
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com>
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
  • Loading branch information
mpvl committed Dec 27, 2024
1 parent a9f4f20 commit e3359f5
Show file tree
Hide file tree
Showing 3 changed files with 161 additions and 321 deletions.
Loading

0 comments on commit e3359f5

Please sign in to comment.