Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gerrithub: fix up gitiles homepage #1101

Closed
myitcv opened this issue Jul 15, 2021 · 6 comments
Closed

gerrithub: fix up gitiles homepage #1101

myitcv opened this issue Jul 15, 2021 · 6 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed infra Issues related to CI, Gerrit, cuelang.org, GitHub, etc

Comments

@myitcv
Copy link
Member

myitcv commented Jul 15, 2021 •
edited
Loading

The navigation bar at the top of the gittiles homepage (https://review.gerrithub.io/plugins/gitiles/cue-lang/cue) is generic and can be made specific to CUE:

https://gerrit.googlesource.com/gitiles/+/HEAD/Documentation/markdown.md#Site-layout
@myitcv myitcv added good first issue Good for newcomers help wanted Extra attention is needed infra Issues related to CI, Gerrit, cuelang.org, GitHub, etc labels Jul 15, 2021
@palmamartin
Copy link
Contributor

Is this still desired? If nobody is working on it, I would like to help here.

@myitcv
Copy link
Member Author

myitcv commented Nov 12, 2021

@palmamartin please do!

@palmamartin
Copy link
Contributor

Just send a CL. Its very basic. It adds a title with the CUE logo. If a more sophisticated navigation bar is preferred with links to documentation etc... please let mi know in the CL.

@cueckoo cueckoo closed this as completed in 28b4257 Dec 6, 2021
@myitcv
Copy link
Member Author

myitcv commented Dec 6, 2021

@palmamartin - thanks for your patience on this. Now submitted... but it doesn't appear to have changed anything? Any ideas?

jlongtine pushed a commit to jlongtine/cue that referenced this issue Dec 8, 2021
@palmamartin @jlongtine
gitiles: customize navigation bar
3a6d011 
Fixes cue-lang#1101

Signed-off-by: Martin Palma <m@palma.bz>
Change-Id: Icf36e6aef8ee6103e7c97c0f3101e9b0abe6c9fc
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/527284
Reviewed-by: Paul Jolly <paul@myitcv.io>
Signed-off-by: Joel Longtine <joel@longtine.io>
@palmamartin
Copy link
Contributor

@myitcv It seems to me that the navbar.md will only be displayed when a markdown file is rendered, see: https://review.gerrithub.io/plugins/gitiles/cue-lang/cue/+/refs/heads/master/doc/install.md

Also "svg" is not a supported image format. Should I submit another CL for changing the image format? Does it need a new issue for that?

@myitcv
Copy link
Member Author

myitcv commented Dec 13, 2021

@myitcv It seems to me that the navbar.md will only be displayed when a markdown file is rendered, see: https://review.gerrithub.io/plugins/gitiles/cue-lang/cue/+/refs/heads/master/doc/install.md

Ah! That explains it, thank you for digging on that.

Should I submit another CL for changing the image format?

Please.

Does it need a new issue for that?

Nope, this one is just fine.

I suggest filled.png from:

https://github.com/cue-lang/cuelang.org/tree/master/static/images

cueckoo pushed a commit that referenced this issue Dec 17, 2021
@palmamartin
gitiles: change logo from SVG to PNG
3924013 
Only PNG (*.png), JPEG (*.jpg or *.jpeg), GIF (*.gif) and WebP (*.webp) image formats
are supported when referenced from the Git repository.

Fixes #1101

Change-Id: If6c9beb7b63150d98afdc17ce896d80cafc6745c
Signed-off-by: Martin Palma <m@palma.bz>
cueckoo pushed a commit that referenced this issue Dec 17, 2021
@palmamartin @mpvl
gitiles: change logo from SVG to PNG
8a40ef0 
Only PNG (*.png), JPEG (*.jpg or *.jpeg), GIF (*.gif) and WebP (*.webp) image formats
are supported when referenced from the Git repository.

Fixes #1101

Change-Id: If6c9beb7b63150d98afdc17ce896d80cafc6745c
Signed-off-by: Martin Palma <m@palma.bz>
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/529576
Unity-Result: CUEcueckoo <cueckoo@cuelang.org>
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Marcel van Lohuizen <mpvl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed infra Issues related to CI, Gerrit, cuelang.org, GitHub, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@palmamartin @myitcv