evalv3: unexpected failure with explicit _|_ in matchN arguments
#3420
Labels
encoding
evaluator
evalv3
issues affecting only the evaluator version 3
jsonschema / openapi
NeedsFix
Comments
|
Why are you writing a bottom like that in your CUE? How did this come about from jsonschema? |
cueckoo
pushed a commit
that referenced
this issue
Sep 3, 2024
This CL updates JSON Schema generation to use the newly added `matchN` primitive for `allOf`, `anyOf` and `oneOf`. This has a much closer correlation with the JSON Schema primitives than the current approach of using CUE's `&` and `|` operators. Specifically: - the schema arguments should not affect the final result other than to validate it, but both `&` and `|` can affect the result. - the result could become non-concrete due to `|` ambiguity in `anyOf`. Although this does fix a bunch of issues, there are some regressions. See issues #3418, #3420, #3422 for details. Comparative test stats (pre-matchN before post-matchN): ``` v2: schema extract (pass / total): 971 / 1637 = 59.3% schema extract (pass / total): 975 / 1637 = 59.6% tests (pass / total): 3081 / 7175 = 42.9% tests (pass / total): 3140 / 7175 = 43.8% tests on extracted schemas (pass / total): 3081 / 3542 = 87.0% tests on extracted schemas (pass / total): 3140 / 3546 = 88.6% v3: schema extract (pass / total): 971 / 1637 = 59.3% schema extract (pass / total): 967 / 1637 = 59.1% tests (pass / total): 3063 / 7175 = 42.7% tests (pass / total): 3074 / 7175 = 42.8% tests on extracted schemas (pass / total): 3063 / 3542 = 86.5% tests on extracted schemas (pass / total): 3074 / 3538 = 86.9% ``` This change also requires that we update the CI generated code and remove the workaround for the previous `oneOf` limitation. Also add a `brokenInV2` tag to the encoding/jsonschema tests to work around the fact that some V2 tests are now broken. For #3380 For #3165 Signed-off-by: Roger Peppe <rogpeppe@gmail.com> Change-Id: I2630a6d2b1614b2479802e788c16249d2cf4aa6b Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1200526 Reviewed-by: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
In JSON Schema, the value |
vanhtuan0409
pushed a commit
to anduintransaction/cue
that referenced
this issue
Oct 15, 2024
This is needed to pass various tests. Bugs still remains, but the main point is that it unblocks a next phase in structure sharing. Issue cue-lang#2854 Issue cue-lang#2850 Issue cue-lang#3165 Fixes cue-lang#3410 Fixes cue-lang#3420 Issue cue-lang#3443 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: Ibd2a41e25e07bd37899620af6bd9665435d68e8a Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1202212 TryBot-Result: CUEcueckoo <cueckoo@cuelang.org> Reviewed-by: Matthew Sackman <matthew@cue.works> Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What version of CUE are you using (
cue version)?Does this issue reproduce with the latest stable release?
N/A
What did you do?
What did you expect to see?
Passing test (and under evalv2, this does indeed pass).
What did you see instead?
The text was updated successfully, but these errors were encountered: