Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update generate.md refer protobuf to golang #371

Closed
wants to merge 41 commits into from
Closed

Update generate.md refer protobuf to golang #371

wants to merge 41 commits into from

Conversation

randomizedcoder
Copy link

Correct documentation to make it clear golang generation from protobuf definitions does not work.
Ref: cue-lang/cue#581

myitcv and others added 30 commits January 3, 2023 09:52
@myitcv
internal/ci: test CLs by using PRs
308f1c8 
By testing CLs via PRs, we can use the fact that a PR has a target
branch. This allows the PR workflow test to use the target branch
actions cache. This is especially significant for the alpha branch
because it is not the default branch.

See the logic in:

https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#matching-a-cache-key

for details on how the action cache is chosen, and why the target branch
is important for CLs that target alpha.

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: I128f8e6a1981be4dad035e8e9ff9f53e5569d636
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/548006
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Chief Cueckoo <chief.cueckoo@gmail.com>
@myitcv
internal/ci: push all active branches from main to trybot repos
3390a3e 
Also keep track of active development branches so that workflows etc can
reference that list. This allows us to fix the fact that alpha should
also build in response to push commits.

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: I4c117ab577758fdec4c58462a630731685192671
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/548008
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Chief Cueckoo <chief.cueckoo@gmail.com>
@myitcv
internal/ci: fix deploy previews
0cea6bb 
Now that we have moved to using PRs to trigger workflow runs in the
trybot repo, github.ref refers to the PR merge branch. Instead we need
to use the reference github.head_ref to extract the branch name.

We also use github.head_ref in order to prevent the deploy of previews
in the trybot repo for anything other than CL branches.

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: I65b184dd007f52513780ba58837e4baaa9a854fe
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/548012
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Chief Cueckoo <chief.cueckoo@gmail.com>
@myitcv
internal/ci: make push_tip_to_trybot a separate workflow
6a27e27 
This more easily allows us to run it for all active branches.

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: Ic503b0f39da802b5beb11b1a1caa9f9be59af38d
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/548016
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Chief Cueckoo <chief.cueckoo@gmail.com>
@myitcv
build: remove stray debugging line.
09d86f8 
Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: If4a99e056b9aa4a087b88d04f11f01aa98a94955
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/548019
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Chief Cueckoo <chief.cueckoo@gmail.com>
@myitcv
internal/ci: make action cache key unique
1610707 
GitHub actions caches are immutable. Therefore, use a key which is
unique, but allow the restore to fallback to the most recent cache.
The result is then saved under the new key which will benefit the
next build

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: Ibbf5eb53f96064bbd41d163d968e51053037d42f
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/548022
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Chief Cueckoo <chief.cueckoo@gmail.com>
@myitcv
gerritstatusupdater: do not try to do anything with non-CL branches
92e7a8e 
Now that we also build non-CL branches in the trybot repo, we need to
ignore events for those branches.

For now, we identify such branches by the absence of a '/'. This is
fairly reasonable, because as repository owners we are in control of all
branches created in this repo.

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: I04a5cf0d28ef5e098e25c4e0f85709e9cffb4f90
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/548025
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Chief Cueckoo <chief.cueckoo@gmail.com>
@myitcv
internal/ci: derive npm and go cache locations
a8f7d03 
This is more cross-platform.

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: I702ec60dcb92d220f41a0e7f06cc48290a306203
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/548056
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Chief Cueckoo <chief.cueckoo@gmail.com>
@myitcv
internal/ci: allow tip deploy to be triggered by repository_dispatch
335e910 
Now that tip.cuelang.org is its own site, deployed from a workflow in
this repo (as opposed to a job that runs on Netlify), we need to be able
to trigger that workflow from other places.  Specifically, we need to be
able to trigger a deploy when we get a new commit at the tip of
cue-lang/cue.

Therefore we update the update_tip workflow in this repository to be
trigger-able via repository_dispatch.

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: I08c2a7a5c1382da642fca4a5ee0503583066d42c
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/548074
Reviewed-by: Chief Cueckoo <chief.cueckoo@gmail.com>
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
@myitcv
internal/ci/netlify: make CL redirect non-repo specific
06aa208 
This allows cuelang.org/cl/N to redirect to the corresponding GerritHub
CL regardless of repo.

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: I01890bdd749f2cbbd6e7c420f4c0c167904fd5d3
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/550022
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
@mvdan
internal/functions: use unique CL IDs to post Gerrit reviews
9d82003 
See the added comments.

Since we now rely on CL numbers to unambiguously post a review,
and very old versions of cueckoo or our workflows did not set those,
gerritstatusupdater will now reject branches without a CL number.

Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
Change-Id: If0db51dc12ce643087e26975d998cbbc7ae12347
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/551168
Reviewed-by: Paul Jolly <paul@myitcv.io>
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
@mvdan @chiefcueckoo
internal/functions: learn the order of numbers again
8161815 
The CL number comes before the patchset in the branch name.

Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
Change-Id: I6ce092254f75c7d755cca111b05e908fe3fb5805
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/551193
Reviewed-by: Chief Cueckoo <chief.cueckoo@gmail.com>
@myitcv @mvdan
site: fix /go redirects
76a8c8f 
Recently we have seen a significant number of requests for /go?go-get=1
return 404 errors.

Also, somewhat counterintuitively, the bare path /go is configured to
404. As a Go developer, seeing the import path cuelang.org/go I might
reasonably expect https://cuelang.org/go to take me somewhere sensible.

As such, the current redirect requires ?go-get=1 to be present, but in
practice we are even seeing some of these fail.

The reason for this is unclear but would appear to be something
Netlify-related because nothing has changed on our side.

The main focus for now is to fix the 404s we are seeing. The simplest
way to do that is to make /go and /go/* both redirect to /golang/go.html
without any condition on a query parameter being present.

As part of this change, temporarily disable the check for the latest CUE
version. This step is regularly failing because of the increased number
of 404 errors. Once we fix the 404s, we can restore this step.

Following this change the following should all redirect to
/golang/go.html:

  /go
  /go?go-get=1
  /go/
  /go/?go-get=1
  /go/cmd/cue
  /go/cmd/cue?go-get=1

(the /go/cmd/cue example covers /go/*)

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: I39411ccb033d307ced5501a2719cc082645d36c2
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/551304
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
@myitcv @mvdan
internal/ci: reenable pull through proxy step in trybots
1e754b7 
Now that we have hopefully fixed the number of 404 errors related to
requests to /go and /go/, reenable the trybot step that ensures we are
using the latest version of the cuelang.org/go module as part of
cuelang.org.

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: I7d49688429b25001e77291df7bb5f0ed75b8ac20
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/551305
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
@myitcv
netlify: redirect /go/* to pkg.go.dev/cuelang.org/go/:splat
088340c 
We currently serve a static HTML file in response to any request for
/go/*. This allows us to serve a go-import meta tag which is used by
cmd/go for resolving the remote import path cuelang.org/go.

The static HTML page currently redirects to
https://pkg.go.dev/cuelang.org/go regardless of the request path suffix,
the elements after /go. This means that a request for /go/cmd/cue
redirects to https://pkg.go.dev/cuelang.org/go, rather than the more
useful https://pkg.go.dev/cuelang.org/go/cmd/cue.

Fix that by using 302 redirects from /go and /go/* to
/golang/go.html?:splat, regardless of query parameter. This allows us to
continue serving the go-import meta tag from the single static HTML, and
with some simple JavaScript in the go.html page we use the query
parameter part of the URL to complete the path for the in-page redirect
to pkg.go.dev.

After this CL, all the following behaviour should result. The first
column is the original path on cuelang.org requested, the second is the
redirect result, the third is the result of the JavaScript redirect to
pkg.go.dev

|-------------------+--------------------------+----------------------|
| Original path     | cuelang.org redir        | pkg.go.dev JS redir  |
|-------------------+--------------------------+----------------------|
| /go               | /golang/go.html          | /cuelang.org/go      |
| /go/              | /golang/go.html          | /cuelang.org/go      |
| /go?go-get=1      | /golang/go.html?go-get=1 | /cuelang.org/go      |
| /go/?go-get=1     | /golang/go.html?go-get=1 | /cuelang.org/go      |
| /go/cue           | /golang/go.html?cue      | /cuelang.org/go/cue  |
| /go/cue/          | /golang/go.html?cue/     | /cuelang.org/go/cue/ |
| /go/cue?go-get=1  | /golang/go.html?cue      | /cuelang.org/go/cue  |
| /go/cue/?go-get=1 | /golang/go.html?cue/     | /cuelang.org/go/cue/ |
|-------------------+--------------------------+----------------------|

Note, the ?go-get=1 query string is dropped when the original path
contains an element after /go/*. This is harmless.

The one thing we should sense check immediately after merging this CL
and the deploy completing is the cmd/go is happy with the 302 redirect
to a static page. Hard to imagine it would be worried about that, but we
should check to be sure.

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: Iee4ffeacdddca08de7a5edd874036bafe406d918
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/551314
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
@myitcv
internal/ci: make Go, Node and Hugo versions consistent with alpha
5b956fa 
This makes applying changes from the default branch, changes related to
the trybot refactors, to the alpha branch cleaner.

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: I5e83429ecd1f94c322709f13d30398921d9fee4b
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/551460
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
@myitcv
internal/ci: move to v0.5.0-beta.5
1b19b5a 
This fixes a few bugs that catch us in later CLs.

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: I7182ade452936e12a3d886e44a84b4502f563721
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/551427
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
@myitcv
internal/ci: use a group of cue commands for go:generate
bf78fbe 
This corresponds to CL 551248 which was applied in the main CUE repo.

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: I2fdeaae47fb82e44deb8cb84a368802bb17413ee
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/551428
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
@myitcv
internal/ci: use base definition to check for porcelain commit
c1f128e 
Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: Ia85b8441eb4cc8ea19e2d95c80cff3ad018dd91e
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/551477
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
@myitcv
internal/ci: remove unused definition
6bc954a 
Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: If69f8f168292746b8f570a04fc6f3b99c5267e8a
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/551476
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
@myitcv
internal/ci: adopt early git checks from alpha
c7cea2c 
These are generally useful.

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: I16d6b1ff0627c98d1812f47c54804868180de1e7
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/551475
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
@myitcv
internal/ci: use ubuntu-22.04
dd16d39 
Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: I96ffec7c31ba34d15a0128533f2df6b5388cec27
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/551873
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
@myitcv
internal/ci: move to go1.20.2
98bb565 
Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: I498d23dcdd7f3adc2d40cbb010a614d7160f9ca3
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/551837
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
@myitcv
internal/ci: refactor the way we declare workflows
3ac5946 
This corresponds to CL 551363 in the main repo.

This change should not result in any .github/workflows changes.

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: If0760439aa849f211203773065e1901e847b0b24
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/551429
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
@myitcv
internal/ci: remove generated workflow files before generating them
42e3a9a 
This corresponds to CL 551625 in the main CUE repo.

This change should not result in any .github/workflows changes.

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: Ib3b18602c6ad673a20052f08cb48944e79f61cc7
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/551866
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
@myitcv
internal/ci: rename core -> repo
6467e55 
This moves us to the pattern of a repo package. It also moves a number
of declarations from workflows.cue into repo.

We no longer use definitions in this package which is more focussed on
being the concrete configuration values required in github and other
packages.

We also move to concept of protectedBranchPatterns.  In the general
case, we need to tell GitHub which branches are protected. Sometimes
this is easy with branches like "master". But in other situations we
would need to list all release branches, e.g.  "release-branch.v0.5"
etc. Instead use a list of patterns to make this general and applicable
over time. This follows the approach in the main CUE repo.

This corresponds to CL 551386, CL 551387 CL 551354 and CL 551776 from
the main CUE repo.

This change does have .github/workflows changes, related to the switch
to use protectedBranchPatterns. However, there should be no effective
change at runtime, i.e. all workflows should run as they did before.

Change-Id: I74f93d9c723b7c30e6134b1656843ac43610fe99
Signed-off-by: Paul Jolly <paul@myitcv.io>
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/551430
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
@myitcv
internal/ci: import repo package once in github package
bc94bae 
This corresponds to CL 551822 and CL 551826 in the main repo.

This change should not result in any .github/workflows changes.

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: Id4e15a670e297b8edb67aba6156cfa2cad8cf49a
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/551834
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
@myitcv
internal/ci: move away from definitions in github
b27a4a9 
We don't have any schema values in the github package, just templates.
Hence we should not use definitions for those, just hidden fields.

This change should not result in any .github/workflows changes.

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: I29c726d5e849d2ace44dc081f4026a191bf0b17a
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/551867
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
@myitcv
internal/ci: baseline against main CUE repo be0601bf pre CI changes
799add9 
The contents of the base package are a mechanical copy from be0601bf in
the main CUE repo.

The changes to all other internal/ci/**/*.cue packages are mechanical
changes in response to that new baseline.

The changes in .github/workflows should strictly improve
correctness/reliability. The net effect of the changes however is
expected to be zero, i.e. site will still deploy a preview, master will
continue to deploy etc.

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: I516d92b31737644e7c2388f13f49a3afaf31a2eb
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/551868
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
@myitcv
all: set GOPRIVATE when grabbing latest versions
14e8ce0 
We have seen countless issues with either proxy.golang.org or
sum.golang.org when trying to go get recent commits/versions.

Side-step these issues by setting GOPRIVATE=cuelang.org/go.

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: I954f77b8aab7b49e7480fedd7e00b19293fd9d97
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/552033
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
myitcv and others added 11 commits April 3, 2023 10:46
@myitcv
gerritstatusupdater: add logic for handling Dispatch-Trailer
164f099 
If we receive an event for a commit that contains a Dispatch-Trailer,
then decode that trailer in preference to trying to parse information
from the branch name for the event.

The main thrust of the change in this CL is the introduction of the
GERRITSTATUSUPDATER_DISPATCH_TRAILER_MODE environment variable. This
controls the processing of events from GitHub. This variable can take
three values: ignore, prefer and require. All are designed to handle the
transition from the old-style branch-based event handling to commit
trailers. A value of "ignore" does not try to find and parse
Dispatch-Trailer in events. "prefer" tries to find and parse
Dispatch-Trailers, and prefers them to branch-based logic if such a
trailer does exist. "require" errors (returning a 500 status code) if an
event does not contain a Dispatch-Trailer.

There is, admittedly, a lot going on in this CL. Ideally it would have
been split into separate CLs for easier review etc. However, we have no
unit/integration tests for gerritstatusupdater. The only way we can
definitively test the thing is to hook it up locally using ngrok and
fire some events through it with real CI builds on GitHub. Splitting up
this CL into multiple CLs would have required doing that manual testing
many times over. So hopefully the assurance that this has been tested
heavily locally, in all three modes of
GERRITSTATUSUPDATER_DISPATCH_TRAILER_MODE is sufficient assurance.

Testing was carried out against the commit ba31dea, patchset 18 in this
CL. First it should be noted that the only thing to change between that
commit and the submitted version of this CL is the commit message.
Gerrit can be consluted for that: CL 551980.

Other changes include:

* Tidying up of the handling of early return in our handler to use a
  locally defined value instead of nil in the panic.
* Fix some bugs identified in the names of environment variables.

Testing
-------

The scenarios we needed to test were as follows:

GERRITSTATUSUPDATER_DISPATCH_TRAILER_MODE=ignore

Verify that we see that we have 2 messages per patchset per CL for a
trybot (or unity) run of state pre new CI setup:

* cue-lang/cue@master: CL 551380 patchset 76
* cue-lang/cuelang.org@master: CL 551918 patchset 26
* cue-lang/cuelang.org@alpha: CL 551936 patchset 15
* cue-unity/unity@main: CL 551912 patchset 27

Verify that we see 0 messages per patchset per CL for a trybot run of
state post new CI setup:

* cue-lang/cue@master: CL 551352 patchset 147, with the workflow run of
  https://github.com/cue-lang/cue-trybot/actions/runs/4593006587
* cue-lang/cuelang.org@master: CL 551434 patchset 58, with the workflow
  run of https://github.com/cue-lang/cuelang.org-trybot/actions/runs/4593024696
* cue-lang/cuelang.org@alpha: CL 552028 patchset 13, with the workflow run
  of https://github.com/cue-lang/cuelang.org-trybot/actions/runs/4593036358
* cue-unity/unity@main: CL 552050 patchset 19, with the workflow run of
  https://github.com/cue-unity/unity-trybot/actions/runs/4593101781

GERRITSTATUSUPDATER_DISPATCH_TRAILER_MODE=prefer

Verify that we see that we have 2 messages per patchset per CL for a
trybot run of state pre new CI setup:

* cue-lang/cue@master: CL 551380 patchset 77
* cue-lang/cuelang.org@master: CL 551918 patchset 27
* cue-lang/cuelang.org@alpha: CL 551936 patchset 16
* cue-unity/unity@main: CL 551912 patchset 28

Verify that we see 1 message per patchset per CL for a trybot run of
state post new CI setup:

* cue-lang/cue@master: CL 551352 patchset 148
* cue-lang/cuelang.org@master: CL 551434 patchset 59
* cue-lang/cuelang.org@alpha: CL 552028 patchset 14
* cue-unity/unity@main: CL 552050 patchset 20

GERRITSTATUSUPDATER_DISPATCH_TRAILER_MODE=require

Verify that we see 1 message per patchset per CL for a trybot run of
state pre new CI setup (error message in logs):

* cue-lang/cue@master: CL 551380 patchset 78
* cue-lang/cuelang.org@master: CL 551918 patchset 28
* cue-lang/cuelang.org@alpha: CL 551936 patchset 17
* cue-unity/unity@main: CL 551912 patchset 30

Verify that we see 1 message per patchset per CL for a trybot run of
state post new CI setup:

* cue-lang/cue@master: CL 551352 patchset 149
* cue-lang/cuelang.org@master: CL 551434 patchset 60
* cue-lang/cuelang.org@alpha: CL 552028 patchset 15
* cue-unity/unity@main: CL 552050 patchset 22

As expected we get the error messages in the local logs:

    2023/04/03 07:43:06 error {"DeliveryID":"c9bb2130-d1ea-11ed-8f0d-c7d9f4cbf786","Repo":"cue-lang/cue-trybot","WorkflowRunID":4593696261,"DispatchTrailerMode":"require","VCSRevision":"ba31deaa"}: failed to find Dispatch-Trailer
    2023/04/03 07:54:26 error {"DeliveryID":"5f0f7910-d1ec-11ed-8771-bbf88393cc82","Repo":"cue-unity/unity-trybot","WorkflowRunID":4593765328,"DispatchTrailerMode":"require","VCSRevision":"ba31deaa"}: failed to find Dispatch-Trailer

which return 500s as expected in the GitHub delivery logs.

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: I3a3a5a9b4e4efd3745e67b9ebd32badb950d95f5
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/551980
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
@myitcv
internal/ci: baseline base against f881884a from main CUE repo
790fcb2 
The contents of the base package are a mechanical copy from f881884a in
the main CUE repo.

This includes switching the base.trybotWorkflows template which
automatically gives us the evict_caches workflow to complement the now
shared Go cache strategy.

We also drop the trybot/*/* branch pattern from the trybot workflow
which has no effect and just adds noise.

The Go cache keys now reflet the fact the trybot workflow only uses a
single Go version and not a matrix.

The update_tip workflow uses the Go cache template in a readonly
capacity.

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: I3c79c9b1d915d4013f1c6e5c013903f7b45d3760
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/551918
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
@myitcv
internal/ci: baseline against main CUE repo post CI changes
973855b 
This needs to wait until CL 551352 lands.

The medium-long term intention is that the base package should be
extracted to a module shared in some way by all repos.

For now we copy-paste from the main repo where the recent changes have
been made.

This brings the master branch of this repo in line with CL 551380 in the
main repo.

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: I2a5f477367fbb94c7eb3a7657cfbfb642a72a8cb
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/551434
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Reviewed-by: Chief Cueckoo <chief.cueckoo@gmail.com>
@myitcv
internal/ci: allow trybot workflows to be workflow_dispatch-ed
d7dd455 
New baseline against 09221a3e in the main CUE repo.

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: I30a14649521414883418479cd97ac404e3b30443
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/552210
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
@myitcv
internal/ci: baseline base against 53d3bc71 from main CUE repo
f71be27 
Baseline from the commit that is merged off the back of
https://cuelang.org/cl/552206.

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: I17bc180f74a53953158ca73fd9c8998562831fe3
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/552216
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
@myitcv
internal/ci: fix deploy alias in trybot workflow
51c6832 
The use of comparison vs _|_ masked an issue with an expression in the
'#alias' field passed to _netlifyDeploy. This resulted in no alias being
used for the deploy of a CL, causing the deploy to default to some
Netlify default (commit ID?). This meant that we no longer had a
predicatable URL for the deploy of a CL trybot run, and hence the deploy
preview link reported on trybot success in CL no longer worked.

Not quite sure when this stopped working, because I'm relatively sure I
clicked through on such a deploy preview link during the recent CI
changes.

Either way, this is now fixed as the trybot results in this CL should
demonstrate.

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: I32fea7fe76f6e2c24b5cbe4c4c11b4b62fd171fc
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/552302
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
@myitcv
deps: upgrade to CUE v0.5.1-0.20230413144408-f681271a38ec
15f879b 
Regenerate the spec and tour against this version.

For now we "pin" to @release-branch.v0.5 within the check in the trybot
workflow because CL 552615 landed after the release of v0.5.0, and we do
not plan to create another v0.5.x release.

Note that we will need to revert this "pin" to @release-branch.v0.5 when
we released v0.6.0.

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: If037299e64c4df2451a1cdf8c2c753b80f10192d
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/552544
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
@myitcv
internal: remove gerritstatusupdater
249e6c8 
This is now handled in the services repo.

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: Ice09f75b4fb369697dda353028f238f9aad46971
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/553894
TryBot-Result: CUEcueckoo <cueckoo+gerrithub@cuelang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
@myitcv
internal/ci: baseline base against 82f96c5e from main CUE repo
8daa893 
Baseline from the commit that is merged off the back of
https://cuelang.org/cl/552365.

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: I3115b67885751ca4f2038a33d9e84d479270a67f
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cuelang.org/+/554226
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: CUEcueckoo <cueckoo+gerrithub@cuelang.org>
@randomizedcoder
Update generate.md not for golang
f1a6923 
Add comment that protobuf to golang generation does not work
cue-lang/cue#581
@randomizedcoder
Merge pull request #1 from randomizedcoder/randomizedcoder-patch-1
28b8252 
Update generate.md not for golang
@randomizedcoder randomizedcoder requested a review from cueckoo as a code owner July 5, 2023 15:34
@netlify
Copy link

netlify bot commented Jul 5, 2023 •
edited
Loading

✅ Deploy Preview for cue ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 28b8252
🔍 Latest deploy log https://app.netlify.com/sites/cue/deploys/64a58d910a79c700072c0afc
😎 Deploy Preview https://deploy-preview-371--cue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@myitcv
Copy link
Member

myitcv commented May 1, 2024

@randomizedcoder apologies for dropping this. The content on the page you updated is vastly improved as part of the new site: https://cuelang.org/docs/concept/how-cue-works-with-protocol-buffers/

@myitcv myitcv closed this May 1, 2024
@randomizedcoder randomizedcoder mentioned this pull request Dec 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cueckoo cueckoo Awaiting requested review from cueckoo cueckoo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@randomizedcoder @myitcv @mvdan