Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for primitive wrappers to not be handled as objects #48

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

jej2003
Copy link
Contributor

@jej2003 jej2003 commented Nov 21, 2023

No description provided.

@jej2003
Copy link
Contributor Author

jej2003 commented Nov 21, 2023

closes #48

@jej2003
Copy link
Contributor Author

jej2003 commented Nov 27, 2023

@briancavalier , just checking in to see if there's anything that I can do to help move this forward? Perhaps there is a better way to implement?

@briancavalier
Copy link
Member

Hey @jej2003 , thanks for the PR! I should have time today to take a look.

Copy link
Member

@briancavalier briancavalier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one minor suggestion.

lib/clone.js Outdated Show resolved Hide resolved
Co-authored-by: Brian Cavalier <brian@briancavalier.com>
@jej2003
Copy link
Contributor Author

jej2003 commented Nov 30, 2023

@briancavalier agree and applied the requested change. Thanks!

Copy link
Member

@briancavalier briancavalier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jej2003!

@briancavalier briancavalier merged commit 035d5ac into cujojs:master Dec 1, 2023
@briancavalier
Copy link
Member

I'll try to publish a new version in the next couple days.

@briancavalier
Copy link
Member

@jej2003 Apologies for not publishing a new version yet.

NPM support is helping us with an issue that's preventing us from publishing. I'll let you know when we've published a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants